-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Improved Visibility styles for responsive design #429
Closed
+89
−56
Closed
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c2a106e
Responsive visibility styles
3den 9cd4237
add slds prefix
3den f44255f
line wraps to follow convention
3den c061ede
minor fixes
3den 9cf4867
fix lint
3den 5f205b4
documentation
3den b3095f9
updating docs
3den File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,3 +13,26 @@ | |
@include visibility(small, $mq-small, $mq-medium); | ||
@include visibility(medium, $mq-medium, $mq-large); | ||
@include visibility(large, $mq-large); | ||
|
||
// Generates responsive visibility tags | ||
@each $key, $value in ( | ||
x-small: $mq-x-small, | ||
small: $mq-small, | ||
medium: $mq-medium, | ||
large: $mq-large, | ||
x-large: $mq-x-large, | ||
) { | ||
@media(min-width: $value) { | ||
// [EXAMPLE] slds-hide--medium: | ||
// HIDES the element when window is BIGGER than medium. | ||
// element will be displayed normaly when window is smaller. | ||
.slds-hide--#{$key} { display: none; } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Property 'display' should be placed on separate line from selector |
||
} | ||
|
||
@media(max-width: $value - 1px) { | ||
// [EXAMPLE] slds-show--medium: | ||
// HIDES the element when window is SMALLER than medium. | ||
// element will be displayed normaly when window is bigger. | ||
.slds-show--#{$key} { display: none; } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Property 'display' should be placed on separate line from selector |
||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you wrap all the keys in single quote?
'x-small'
...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍