Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support slds-min-<SIZE>-hide #263

Closed
dsharrison opened this issue Jun 29, 2016 · 7 comments
Closed

Support slds-min-<SIZE>-hide #263

dsharrison opened this issue Jun 29, 2016 · 7 comments

Comments

@dsharrison
Copy link

dsharrison commented Jun 29, 2016

The responsive utilities provided by SLDS are great for hiding elements, but I have been having trouble with them in respect to showing elements only to small screens. My request is to support a slds-min-<SIZE>-hide class that will behave much like slds-min-<SIZE>-hide but instead of hiding the element below a certain breakpoint will hide an element above a certain breakpoint. This would allow for rendering certain elements only for screen sizes below 480px for example.

If there is already a way to achieve this today and I am just missing something I would be happy to hear that too.

dsharrison added a commit to dsharrison/design-system that referenced this issue Jun 30, 2016
Fix salesforce-ux#263 by adding support for slds-max-size-show.

Breakpoints are set so that visibility occurs at one pixel below the
min-breakpoint. This keeps the current definition of the “max”
attribute being exclusive. This means an element will be shown for
widths up to but not including the pixel value of the max-size
specified.
@dsharrison
Copy link
Author

I am happy to create a pull request with this enhancement but before I do I would just like to check and see if there was a conscious reason this wasn't in the framework.

@kaelig
Copy link
Contributor

kaelig commented Jun 30, 2016

Thank you for reporting this, @dsharrison!

Mobile support will be our focus very soon and we will definitely look into it.

@dsharrison dsharrison changed the title Support slds-max-<SIZE>-show Support slds-min-<SIZE>-hide Jul 3, 2016
@3den
Copy link

3den commented Aug 11, 2016

👍

@3den
Copy link

3den commented Aug 11, 2016

i always get confuse with the responsive show/hide classes we currently have on SLDS, we have adding the min/max prefix to all responsive show/hide classes would help a lot.

Also seems like the proper BEM naming convention for this should be slds-show--min-<SIZE> or slds-hide--max-<SIZE> coz the size condition is the modifier that toggles the effect on/off.

@3den
Copy link

3den commented Feb 7, 2017

Any ETA of when this feature will be implemented?

@elvisbegovic
Copy link

+1

@stale
Copy link

stale bot commented Jun 30, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you still need help with your issue, please comment and we will reply to you shortly. Thank you for your contributions to the Salesforce Lightning Design System.

@stale stale bot unassigned jina Jun 30, 2018
@stale stale bot added the stale label Jun 30, 2018
@stale stale bot closed this as completed Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants