Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sales path title text cut off #135

Closed
jorgjanke opened this issue Dec 11, 2015 · 8 comments
Closed

Sales path title text cut off #135

jorgjanke opened this issue Dec 11, 2015 · 8 comments
Assignees

Comments

@jorgjanke
Copy link

The path titles (labels) of the Tab Sales Path are not rendered correctly:
2015-12-11_14-19-27
The left side can be improved by

.slds-tabs--path__title {
  padding-left: 0.15rem;
}

(or increasing the padding on slds-tabs--path__link)

but did not find a solution for the right side.
The truncate
text-overflow: ellipsis
on slds-tabs--path__link does not apply

@kaelig
Copy link
Contributor

kaelig commented Dec 12, 2015

Thank you @jorgjanke for reporting yet another issue, this is very helpful.

Can you specify what browser (+ version) and device the bug appears in?

@jorgjanke
Copy link
Author

has nothing to do with browser. the OS does not start it. this was Path
Finder - same happens when starting from Finder or command line

Jorg Janke - www.accorto.com - (650) 227-3271

On Fri, Dec 11, 2015 at 4:01 PM, Kaelig [email protected] wrote:

Thank you @jorgjanke https://github.com/jorgjanke for reporting yet
another issue, this is very helpful.

Can you specify what browser (+ version) and device the bug appears in?


Reply to this email directly or view it on GitHub
#135 (comment)
.

@kaelig
Copy link
Contributor

kaelig commented Dec 14, 2015

the OS does not start it. this was Path
Finder - same happens when starting from Finder or command line

Can you clarify? I'm not sure I follow. Is this related to this issue?

@jorgjanke
Copy link
Author

... uups very sorry - mixed up with a very different issue.

The screenshot was Chrome, but same happens in Safari and FF. Looking at the css, I think it not browser specific. Demo:
http://lightningdart.com/#/desktop
click on / navigate to: Tabs
It's basically happening if the component is limited in width.
It's independent from the overflow: auto on tabs--path (then it exceeds the boundary set in the parent div)

@stefsullrew
Copy link
Contributor

I see the bug. Thanks @jorgjanke — I'm working on some other issues in Sales path now, so I'll fix this truncation. For now, if you need to fix it, you can move the four truncation properties from the <a> to the .slds-tabs--path__title.

@jorgjanke
Copy link
Author

Thanks - although to keep the truncation in general would be a good feature in case the labels are very long.

@stefsullrew
Copy link
Contributor

We are keeping the truncation. I just made it work properly. ;)

@kaelig
Copy link
Contributor

kaelig commented Dec 15, 2015

Thanks again @jorgjanke, we've made the change on our side and the fix will be available very soon on this very repository.

@kaelig kaelig closed this as completed Dec 15, 2015
aputinski added a commit that referenced this issue Mar 3, 2016
Handling GitHubButton mounted state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants