saleor 1563 nextjs integration #955

piotrgrundas · 2020-11-22T20:09:11Z

I want to merge this change because...

Screenshots

Pull Request Checklist

All visible strings are translated with proper context.
All data-formatting is locale-aware (dates, numbers, and so on).
The changes are tested.
The code is documented (docstrings, project documentation).
Changes are mentioned in the changelog.

Test Environment Config

API_URI=https://master.staging.saleor.rocks/graphql/

lgtm-com · 2020-11-22T20:13:28Z

This pull request introduces 6 alerts when merging 7dd3f40 into d493e1b - view on LGTM.com

new alerts:

6 for Unused variable, import, function or class

lgtm-com · 2020-11-23T21:59:20Z

This pull request introduces 9 alerts when merging 270f658 into d493e1b - view on LGTM.com

new alerts:

8 for Unused variable, import, function or class
1 for Assignment to constant

lgtm-com · 2020-11-23T23:08:13Z

This pull request introduces 8 alerts when merging 8764d94 into d493e1b - view on LGTM.com

new alerts:

8 for Unused variable, import, function or class

lgtm-com · 2020-11-25T00:43:29Z

This pull request introduces 4 alerts when merging 44c0c66 into d493e1b - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class
1 for Unreachable statement
1 for Useless conditional

lgtm-com · 2020-11-25T23:13:03Z

This pull request introduces 3 alerts when merging b3698c5 into d493e1b - view on LGTM.com

new alerts:

2 for Useless conditional
1 for Unused variable, import, function or class

… into feature/SALEOR-1563-nextjs-integration

lgtm-com · 2020-11-26T20:43:42Z

This pull request introduces 2 alerts when merging cbe3952 into 5aaa9f7 - view on LGTM.com

new alerts:

2 for Useless conditional

lgtm-com · 2020-11-26T22:08:47Z

This pull request introduces 2 alerts when merging 3e8a4ab into 5aaa9f7 - view on LGTM.com

new alerts:

2 for Useless conditional

lgtm-com · 2020-11-26T23:02:16Z

This pull request introduces 2 alerts when merging e011af5 into 5aaa9f7 - view on LGTM.com

new alerts:

2 for Useless conditional

lgtm-com · 2020-11-29T13:49:39Z

This pull request introduces 2 alerts when merging 6555314 into 5aaa9f7 - view on LGTM.com

new alerts:

2 for Useless conditional

lgtm-com · 2020-11-29T13:56:19Z

This pull request introduces 2 alerts when merging b7d73b1 into 5aaa9f7 - view on LGTM.com

new alerts:

2 for Useless conditional

lgtm-com · 2020-12-01T22:16:46Z

This pull request introduces 2 alerts when merging a71c7ac into 5aaa9f7 - view on LGTM.com

new alerts:

2 for Useless conditional

lgtm-com · 2020-12-01T22:26:37Z

This pull request introduces 2 alerts when merging 77b2858 into 5aaa9f7 - view on LGTM.com

new alerts:

2 for Useless conditional

… into feature/SALEOR-1563-nextjs-integration

lgtm-com · 2020-12-02T20:52:08Z

This pull request introduces 2 alerts when merging 59b1fa1 into 1abbf68 - view on LGTM.com

new alerts:

2 for Useless conditional

lgtm-com · 2020-12-02T21:30:16Z

This pull request introduces 2 alerts when merging d1914eb into 1abbf68 - view on LGTM.com

new alerts:

2 for Useless conditional

lgtm-com · 2020-12-03T20:07:44Z

This pull request introduces 3 alerts when merging 2cb4c67 into 1abbf68 - view on LGTM.com

new alerts:

2 for Useless conditional
1 for Unused variable, import, function or class

piotrgrundas · 2020-12-03T21:33:46Z

config/next/config.serviceWorker.js

+       *    /\?(.+&)?no-cache=1$/,
+       *  ],
+       *  Or NetworkOnly might have the same effect.
+       */


I'll get back to this after some SSR work to validate it so I want to leave it for now.

piotrgrundas · 2020-12-03T21:36:08Z

src/@next/components/molecules/OrderTabel/OrderTable.tsx

+                          : paths.accountOrderDetail,
+                        query: { token: order.node.token },
+                      }}
+                      key={order.node.number}


Renamed it coz of typo and added ^ Link.

lgtm-com · 2020-12-03T21:37:04Z

This pull request introduces 2 alerts when merging e255680 into 1abbf68 - view on LGTM.com

new alerts:

2 for Useless conditional

piotrgrundas · 2020-12-03T21:37:11Z

src/@next/components/organisms/Overlay/Overlay.tsx

+    if (target) {
+      setPortalTarget(target);
+    }
+  }, [target]);


Needed coz of SSR build.

piotrgrundas · 2020-12-03T21:48:32Z

src/history.ts

+    }
+  });
+  return history;
+})() as History;


Temporary hack so checkout could work on react router.

lgtm-com · 2020-12-03T21:51:57Z

This pull request introduces 1 alert when merging 824c868 into 1abbf68 - view on LGTM.com

new alerts:

1 for Useless conditional

piotrgrundas · 2020-12-03T22:11:03Z

tsconfig.json

  },
  "exclude": ["node_modules"],
+  "include": ["next-env.d.ts", "**/*.ts", "**/*.tsx"]


Next modifies tsconfig on the first run 🤷‍♂️

lgtm-com · 2020-12-03T22:15:58Z

This pull request introduces 1 alert when merging fe71869 into 1abbf68 - view on LGTM.com

new alerts:

1 for Useless conditional

piotrgrundas added 4 commits November 15, 2020 22:44

Initial structure

75b07b4

Adjust product page

a7ab60a

Adjust login page

a0eb6d0

Adjust product, category, collection, cart pages

7dd3f40

piotrgrundas force-pushed the feature/SALEOR-1563-nextjs-integration branch from e2e9ae9 to 270f658 Compare November 23, 2020 21:54

Adjust pages, account confirm, reset password views

8764d94

piotrgrundas force-pushed the feature/SALEOR-1563-nextjs-integration branch from 270f658 to 8764d94 Compare November 23, 2020 23:01

Adjust search, account views. Checkout first adjustments

44c0c66

Adjust pages, account confirm, reset password views

58f0573

piotrgrundas force-pushed the feature/SALEOR-1563-nextjs-integration branch from b3698c5 to 84a744d Compare November 26, 2020 20:36

Merge branch 'feature/nextjs' of github.com:mirumee/saleor-storefront…

cbe3952

… into feature/SALEOR-1563-nextjs-integration

piotrgrundas force-pushed the feature/SALEOR-1563-nextjs-integration branch from 84a744d to cbe3952 Compare November 26, 2020 20:37

Fix problems after rebase

3e8a4ab

piotrgrundas force-pushed the feature/SALEOR-1563-nextjs-integration branch from d976544 to 727d55f Compare November 26, 2020 22:57

Fix problems after rebase, add env files

e011af5

piotrgrundas force-pushed the feature/SALEOR-1563-nextjs-integration branch from 727d55f to e011af5 Compare November 26, 2020 22:57

piotrgrundas changed the title ~~Feature/saleor 1563 nextjs integration~~ saleor 1563 nextjs integration Nov 29, 2020

Fix channels, checkout. Improve envs setup

b7d73b1

piotrgrundas force-pushed the feature/SALEOR-1563-nextjs-integration branch from 6555314 to b7d73b1 Compare November 29, 2020 13:51

piotrgrundas force-pushed the feature/SALEOR-1563-nextjs-integration branch from 450c8b5 to a71c7ac Compare December 1, 2020 22:11

Cleanup settings, split them into separate configurations, add sw config

77b2858

piotrgrundas force-pushed the feature/SALEOR-1563-nextjs-integration branch from a71c7ac to 77b2858 Compare December 1, 2020 22:21

Merge branch 'feature/nextjs' of github.com:mirumee/saleor-storefront…

59b1fa1

… into feature/SALEOR-1563-nextjs-integration

Cleanup paths hell 🔥

d1914eb

Fix storybook

2cb4c67

piotrgrundas force-pushed the feature/SALEOR-1563-nextjs-integration branch 3 times, most recently from 17f7247 to e255680 Compare December 3, 2020 21:30

piotrgrundas commented Dec 3, 2020

View reviewed changes

piotrgrundas force-pushed the feature/SALEOR-1563-nextjs-integration branch 2 times, most recently from 15486f8 to 824c868 Compare December 3, 2020 21:46

piotrgrundas commented Dec 3, 2020

View reviewed changes

src/history.ts

}

});

return history;

})() as History;

Copy link

Contributor Author

piotrgrundas Dec 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary hack so checkout could work on react router.

piotrgrundas commented Dec 3, 2020

View reviewed changes

Fix tests, minor improvements

fe71869

piotrgrundas force-pushed the feature/SALEOR-1563-nextjs-integration branch from 824c868 to fe71869 Compare December 3, 2020 22:11

piotrgrundas closed this Dec 3, 2020

piotrgrundas deleted the feature/SALEOR-1563-nextjs-integration branch December 3, 2020 22:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

saleor 1563 nextjs integration #955

saleor 1563 nextjs integration #955

piotrgrundas commented Nov 22, 2020 •

edited

Loading

lgtm-com bot commented Nov 22, 2020

lgtm-com bot commented Nov 23, 2020

lgtm-com bot commented Nov 23, 2020

lgtm-com bot commented Nov 25, 2020

lgtm-com bot commented Nov 25, 2020

lgtm-com bot commented Nov 26, 2020

lgtm-com bot commented Nov 26, 2020

lgtm-com bot commented Nov 26, 2020

lgtm-com bot commented Nov 29, 2020

lgtm-com bot commented Nov 29, 2020

lgtm-com bot commented Dec 1, 2020

lgtm-com bot commented Dec 1, 2020

lgtm-com bot commented Dec 2, 2020

lgtm-com bot commented Dec 2, 2020

lgtm-com bot commented Dec 3, 2020

piotrgrundas Dec 3, 2020

piotrgrundas Dec 3, 2020

lgtm-com bot commented Dec 3, 2020

piotrgrundas Dec 3, 2020

piotrgrundas Dec 3, 2020

lgtm-com bot commented Dec 3, 2020

piotrgrundas Dec 3, 2020

lgtm-com bot commented Dec 3, 2020

saleor 1563 nextjs integration #955

saleor 1563 nextjs integration #955

Conversation

piotrgrundas commented Nov 22, 2020 • edited Loading

Screenshots

Pull Request Checklist

Test Environment Config

lgtm-com bot commented Nov 22, 2020

lgtm-com bot commented Nov 23, 2020

lgtm-com bot commented Nov 23, 2020

lgtm-com bot commented Nov 25, 2020

lgtm-com bot commented Nov 25, 2020

lgtm-com bot commented Nov 26, 2020

lgtm-com bot commented Nov 26, 2020

lgtm-com bot commented Nov 26, 2020

lgtm-com bot commented Nov 29, 2020

lgtm-com bot commented Nov 29, 2020

lgtm-com bot commented Dec 1, 2020

lgtm-com bot commented Dec 1, 2020

lgtm-com bot commented Dec 2, 2020

lgtm-com bot commented Dec 2, 2020

lgtm-com bot commented Dec 3, 2020

piotrgrundas Dec 3, 2020

Choose a reason for hiding this comment

piotrgrundas Dec 3, 2020

Choose a reason for hiding this comment

lgtm-com bot commented Dec 3, 2020

piotrgrundas Dec 3, 2020

Choose a reason for hiding this comment

piotrgrundas Dec 3, 2020

Choose a reason for hiding this comment

lgtm-com bot commented Dec 3, 2020

piotrgrundas Dec 3, 2020

Choose a reason for hiding this comment

lgtm-com bot commented Dec 3, 2020

piotrgrundas commented Nov 22, 2020 •

edited

Loading