This repository has been archived by the owner on Jul 14, 2022. It is now read-only.
Add adyen gateway #845
Merged
Add adyen gateway #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orzechdev
force-pushed
the
feature/adyen-gateway
branch
from
f71e44f to
b37a0a9
Compare
orzechdev
force-pushed
the
feature/adyen-gateway
branch
from
b37a0a9 to
2e0e2c8
Compare
orzechdev
force-pushed
the
feature/adyen-gateway
branch
from
254caa8 to
d481d68
Compare
orzechdev
force-pushed
the
feature/adyen-gateway
branch
from
d481d68 to
13dc740
Compare
orzechdev
force-pushed
the
feature/adyen-gateway
branch
from
e557d05 to
a315403
Compare
orzechdev
force-pushed
the
feature/adyen-gateway
branch
from
1a74498 to
a473966
Compare
|
Locally all tests passed. Staging tests did not pass due to bug on staging. |
dominik-zeglen
suggested changes
Aug 18, 2020
src/@next/components/organisms/AdyenPaymentGateway/AdyenPaymentGateway.tsx
Outdated
Show resolved
Hide resolved
src/@next/components/organisms/AdyenPaymentGateway/AdyenPaymentGateway.tsx
Outdated
Show resolved
Hide resolved
src/@next/components/organisms/AdyenPaymentGateway/AdyenPaymentGateway.tsx
Outdated
Show resolved
Hide resolved
src/@next/components/organisms/AdyenPaymentGateway/AdyenPaymentGateway.tsx
Outdated
Show resolved
Hide resolved
src/@next/components/organisms/AdyenPaymentGateway/AdyenPaymentGateway.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| useEffect(() => { | ||
| if (dropin) { | ||
| (formRef?.current as any)?.addEventListener("submitComplete", () => { |
There was a problem hiding this comment.
Where does this event come from?
There was a problem hiding this comment.
It comes from CheckoutReviewSubpage component - in other words submitComplete is called when a user clicks the complete checkout button (in the case when gateway may require additional actions like 3d secure confirmation, otherwise completeCheckout method from SDK is called immediately - moreover probably such an event will need to be used also when we will be implementing 3d secure for Stripe, Braintree or other gateways).
orzechdev
force-pushed
the
feature/adyen-gateway
branch
from
6fb425d to
ba1aea4
Compare
|
Task linked: CU-7grfen CVC Declined |
|
Task linked: CU-7guf3e Unable to do a checkout on FF |
michalina-graczyk
suggested changes
Aug 24, 2020
orzechdev
force-pushed
the
feature/adyen-gateway
branch
from
f59f5c0 to
2a1cd85
Compare
AlicjaSzu
approved these changes
Aug 25, 2020
michalina-graczyk
approved these changes
Aug 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this change because... it adds Adyen payment gateway.
Please test it on
127.0.0.1:3000, as Adyen has client key configured for this particular address, it will not work withlocalhost:3000.API branch to test with
master(oradyen_integrationalready merged)Screenshots
Pull Request Checklist
Test Environment Config
API_URI=https://master.staging.saleor.rocks/graphql/