Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add switch to make attribute available in product list column selection #99

Merged
merged 5 commits into from
Aug 21, 2019

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it adds switch "Add to Column Options".

Screenshots

Screenshot 2019-08-12 at 15 17 57

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Number of API calls is optimized.
  4. The changes are tested.
  5. Type definitions are up to date.
  6. Changes are mentioned in the changelog.

@dominik-zeglen dominik-zeglen force-pushed the add/is-attribute-filterable-switch branch from eeb063e to 4f4a345 Compare August 12, 2019 13:23
@codecov
Copy link

codecov bot commented Aug 12, 2019

Codecov Report

Merging #99 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
+ Coverage   88.09%   88.09%   +<.01%     
==========================================
  Files         703      703              
  Lines       11053    11055       +2     
  Branches      927      927              
==========================================
+ Hits         9737     9739       +2     
  Misses       1161     1161              
  Partials      155      155
Impacted Files Coverage Δ
...onents/AttributeProperties/AttributeProperties.tsx 100% <ø> (ø) ⬆️
...ributes/components/AttributePage/AttributePage.tsx 95.91% <100%> (+0.08%) ⬆️
src/attributes/fixtures.ts 100% <100%> (ø) ⬆️
src/types/globalTypes.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bfb307...1138f53. Read the comment docs.

@dominik-zeglen dominik-zeglen force-pushed the add/is-attribute-filterable-switch branch from 4f4a345 to 1138f53 Compare August 21, 2019 13:30
@dominik-zeglen dominik-zeglen merged commit f89ff79 into master Aug 21, 2019
@dominik-zeglen dominik-zeglen deleted the add/is-attribute-filterable-switch branch August 21, 2019 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants