Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata editor to page views #782

Merged
merged 2 commits into from
Oct 28, 2020
Merged

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it adds metadata editor to page views.

PR intended to be tested with API branch: add/pages-metadata-1414

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Data-test are added for new elements.
  7. Type definitions are up to date.
  8. Changes are mentioned in the changelog.

Test environment config

API_URI=https://master.staging.saleor.rocks/graphql/

@github-actions github-actions bot temporarily deployed to add-pages-metadata-1413 October 20, 2020 13:18 Inactive
@github-actions github-actions bot temporarily deployed to storybook add-pages-metadata-1413 October 20, 2020 13:18 Inactive
@patrys
Copy link
Member

patrys commented Oct 20, 2020

@github-actions github-actions bot temporarily deployed to add-pages-metadata-1413 October 20, 2020 13:24 Inactive
@github-actions github-actions bot temporarily deployed to storybook add-pages-metadata-1413 October 20, 2020 13:24 Inactive
@dominik-zeglen dominik-zeglen merged commit a0939a5 into master Oct 28, 2020
@dominik-zeglen dominik-zeglen deleted the add/pages-metadata-1413 branch October 28, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants