Allow taxes to be configured per product #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominik-zeglen
requested review from
krzysztofwolski,
orzechdev,
AlicjaSzu,
korycins and
bmigirl
dominik-zeglen
force-pushed
the
add/taxes-per-product
branch
from
834579a to
5b6a420
Compare
github-actions
bot
temporarily deployed
to
storybook add-taxes-per-product
korycins
approved these changes
Sep 25, 2020
|
Task linked: SALEOR-1129 Implement taxes per product |
orzechdev
suggested changes
Sep 25, 2020
src/taxes/queries.ts
Outdated
| } | ||
| } | ||
| `; | ||
| export const useTaxTypeListt = makeQuery<TaxTypeList, {}>(taxTypeList); |
bmigirl
approved these changes
Sep 25, 2020
orzechdev
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this change because it adds tax configuration at the product level.
Also improves autocomplete ux by limiting rendered items quantity, which no longer lags if there are more than 100 items in menu.
PR intended to be tested with API branch: fix_for_returned_taxcode
Screenshots
Pull Request Checklist
Test environment config
API_URI=https://master.staging.saleor.rocks/graphql/