Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix not closed modal with two confirmations #699

Merged
merged 2 commits into from
Sep 9, 2020
Merged

Fix not closed modal with two confirmations #699

merged 2 commits into from
Sep 9, 2020

Conversation

orzechdev
Copy link
Contributor

@orzechdev orzechdev commented Sep 8, 2020 •
edited
Loading

I want to merge this change because... it fixes not closing order address update modal and double submission of these addresses.

PR intended to be tested with API branch:

Screenshots

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Data-test are added for new elements.
  7. Type definitions are up to date.
  8. Changes are mentioned in the changelog.

Test environment config

API_URI=https://master.staging.saleor.rocks/graphql/

@github-actions github-actions bot temporarily deployed to fix-address-dialog-submit September 8, 2020 14:19 Inactive
@github-actions github-actions bot temporarily deployed to fix-address-dialog-submit September 8, 2020 14:26 Inactive
@orzechdev orzechdev force-pushed the fix/address-dialog-submit branch from c4764ff to 0a3c914 Compare September 8, 2020 14:27
@github-actions github-actions bot temporarily deployed to fix-address-dialog-submit September 8, 2020 14:27 Inactive
@patrys
Copy link
Member

patrys commented Sep 8, 2020

Task linked: CU-70t0du "Edit Billing Address" modal shows two confirmations and does not close

@orzechdev orzechdev merged commit 731d15c into master Sep 9, 2020
@orzechdev orzechdev deleted the fix/address-dialog-submit branch September 9, 2020 09:25
@patrys
Copy link
Member

patrys commented Sep 15, 2020

Task linked: SALEOR-1030 Confirm button for Edit address in Draft order doesn't close the pop up window

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzysztofwolski krzysztofwolski krzysztofwolski approved these changes

@AlicjaSzu AlicjaSzu AlicjaSzu approved these changes

@dominik-zeglen dominik-zeglen Awaiting requested review from dominik-zeglen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@orzechdev @patrys @krzysztofwolski @AlicjaSzu