Add metadata to orders #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominik-zeglen
requested review from
krzysztofwolski,
orzechdev and
AlicjaSzu
|
Task linked: CU-7pqnkd Add metadata to order views |
dominik-zeglen
force-pushed
the
metadata/orders
branch
from
b417221 to
6bb2765
Compare
orzechdev
reviewed
Sep 3, 2020
| @@ -235,7 +235,7 @@ export function hasErrors(errorList: UserError[] | null): boolean { | |||
| export function getMutationState( | |||
| called: boolean, | |||
| loading: boolean, | |||
| ...errorList: UserError[][] | |||
| ...errorList: any[][] | |||
There was a problem hiding this comment.
Well, we only need info how many errors were returned, it's no use for us to know what errors
There was a problem hiding this comment.
What do we gain from turning this into any? What if we wanted to explicitly forbid using any tomorrow to get stronger type checking?
krzysztofwolski
approved these changes
Sep 3, 2020
There was a problem hiding this comment.
I have the the same question as @orzechdev. Besides that - LGTM
AlicjaSzu
approved these changes
Sep 4, 2020
dominik-zeglen
force-pushed
the
metadata/orders
branch
from
6bb2765 to
9ff8f0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this change because it adds metadata editor to order view.
PR intended to be tested with API branch: master
Pull Request Checklist
Test environment config
API_URI=https://master.staging.saleor.rocks/graphql/