Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigator button rendering on safari browser #656

Merged
merged 3 commits into from
Aug 21, 2020

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because Safari wasn't rendering navigator button properly

PR intended to be tested with API branch: master

Screenshots

Screenshot 2020-08-18 at 11 11 54

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Data-test are added for new elements.
  7. Type definitions are up to date.
  8. Changes are mentioned in the changelog.

Test environment config

API_URI=https://master.staging.saleor.rocks/graphql/

@github-actions github-actions bot temporarily deployed to fix-navigator-button August 18, 2020 10:06 Inactive
@github-actions github-actions bot temporarily deployed to fix-navigator-button August 18, 2020 10:07 Inactive
@dominik-zeglen dominik-zeglen requested review from AlicjaSzu and removed request for akjanik August 20, 2020 11:46
@github-actions github-actions bot temporarily deployed to fix-navigator-button August 20, 2020 14:40 Inactive
@dominik-zeglen dominik-zeglen merged commit 871ee11 into master Aug 21, 2020
@dominik-zeglen dominik-zeglen deleted the fix/navigator-button branch August 21, 2020 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants