Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/unassign user #637

Merged
merged 5 commits into from
Aug 20, 2020
Merged

Fix/unassign user #637

merged 5 commits into from
Aug 20, 2020

Conversation

eaglesemanation
Copy link
Contributor

I want to merge this change to fix #498

PR intended to be tested with API branch: master

Screenshots

  • Before:
    before

  • After:
    after

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Data-test are added for new elements.
  7. Type definitions are up to date.
  8. Changes are mentioned in the changelog.

Test environment config

API_URI=https://master.staging.saleor.rocks/graphql/

Info messages should not require any kind of confirmation, so I added
option to disable ConfirmButton by providing "info" as a variant
@krzysztofwolski
Copy link
Member

@eaglesemanation Thank you! :)

@dominik-zeglen dominik-zeglen merged commit df82342 into saleor:master Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Unassign user" pop up uses wrong format when user doesn't have required permissions
4 participants