Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor authorization #624

Merged
merged 23 commits into from
Jul 30, 2020
Merged

Refactor authorization #624

merged 23 commits into from
Jul 30, 2020

Conversation

dominik-zeglen
Copy link
Contributor

@dominik-zeglen dominik-zeglen commented Jul 23, 2020 •
edited
Loading

I want to merge this change because it fixes bugs and adds tests. Also handles expired tokens.

PR intended to be tested with API branch: master

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

Test environment config

API_URI=https://master.staging.saleor.rocks/graphql/

@github-actions github-actions bot temporarily deployed to ref-auth July 27, 2020 10:33 Inactive
@dominik-zeglen dominik-zeglen marked this pull request as ready for review July 27, 2020 11:24
@github-actions github-actions bot temporarily deployed to ref-auth July 27, 2020 11:26 Inactive
krzysztofwolski
krzysztofwolski approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@krzysztofwolski krzysztofwolski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides API_URI comment everything looks 👌

testUtils/api.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to ref-auth July 28, 2020 10:35 Inactive
@github-actions github-actions bot temporarily deployed to ref-auth July 28, 2020 11:02 Inactive
@github-actions github-actions bot temporarily deployed to ref-auth July 29, 2020 13:12 Inactive
@github-actions github-actions bot temporarily deployed to ref-auth July 29, 2020 13:19 Inactive
@github-actions github-actions bot temporarily deployed to ref-auth July 29, 2020 13:35 Inactive
@dominik-zeglen dominik-zeglen merged commit 5062d35 into master Jul 30, 2020
@dominik-zeglen dominik-zeglen deleted the ref/auth branch July 30, 2020 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orzechdev orzechdev orzechdev approved these changes

@krzysztofwolski krzysztofwolski krzysztofwolski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dominik-zeglen @krzysztofwolski @orzechdev