Improve local search + improve Navigator Search UI #5009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7bae942 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Cloud11PL
changed the title
Cloud11PL
force-pushed
the
MERX-625-migrate-from-fuzzaldrin
branch
from
8b42733 to
881f086
Compare
Cloud11PL
changed the title
poulch
previously approved these changes
Jul 1, 2024
Comment on lines
6
to
14
| const reactIntl = jest.requireActual("react-intl"); | ||
| const intl = reactIntl.createIntl({ | ||
| locale: "en", | ||
| }); | ||
|
|
||
| return { | ||
| ...reactIntl, | ||
| useIntl: () => intl, | ||
| }; |
There was a problem hiding this comment.
suggestion: using actual react-intl does not have sense because it doesn't work without context
There was a problem hiding this comment.
It does 😄 Related issue: formatjs/formatjs#1477 (comment)
There was a problem hiding this comment.
Nope it doesn't, it works in your case because you mocked useIntl, but you could do this like that:
Suggested change
| const reactIntl = jest.requireActual("react-intl"); | |
| const intl = reactIntl.createIntl({ | |
| locale: "en", | |
| }); | |
| return { | |
| ...reactIntl, | |
| useIntl: () => intl, | |
| }; | |
| jest.mock("react-intl", () => ({ | |
| useIntl: jest.fn(() => ({ | |
| formatMessage: jest.fn(x => x.defaultMessage), | |
| })), | |
| })); |
There was a problem hiding this comment.
I meant that it does work 😄
There was a problem hiding this comment.
@Cloud11PL test should mock dependencies, not mock and provide their actual implementation. You are not testing react-intl here, you test only your code and the only you care about is that your code calls intl with proper arguments.
andrzejewsky
requested changes
Jul 1, 2024
poulch
reviewed
Jul 1, 2024
poulch
approved these changes
Jul 1, 2024
andrzejewsky
approved these changes
Jul 1, 2024
luiz-linkezio
pushed a commit
to luiz-linkezio/PENTEST-saleor-dashboard
that referenced
this pull request
Jul 4, 2024
* migrate from fuzzaldrin to fusejs * fix types * improve navigator search + port to new macaw-ui * fix type issue * fixes * final fixes * add fuzzySearch separate test * cr fixes * cr fixes
luiz-linkezio
pushed a commit
to luiz-linkezio/PENTEST-saleor-dashboard
that referenced
this pull request
Jul 4, 2024
* migrate from fuzzaldrin to fusejs * fix types * improve navigator search + port to new macaw-ui * fix type issue * fixes * final fixes * add fuzzySearch separate test * cr fixes * cr fixes
luiz-linkezio
pushed a commit
to luiz-linkezio/PENTEST-saleor-dashboard
that referenced
this pull request
Jul 4, 2024
* migrate from fuzzaldrin to fusejs * fix types * improve navigator search + port to new macaw-ui * fix type issue * fixes * final fixes * add fuzzySearch separate test * cr fixes * cr fixes
Cloud11PL
added a commit
that referenced
this pull request
Jul 8, 2024
* migrate from fuzzaldrin to fusejs * fix types * improve navigator search + port to new macaw-ui * fix type issue * fixes * final fixes * add fuzzySearch separate test * cr fixes * cr fixes
Cloud11PL
added a commit
that referenced
this pull request
Jul 8, 2024
* migrate from fuzzaldrin to fusejs * fix types * improve navigator search + port to new macaw-ui * fix type issue * fixes * final fixes * add fuzzySearch separate test * cr fixes * cr fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fuzzaldrinwithfuse.jsWhat type of PR is this?
Related Issues or Documents
Usage Instructions, Screenshots, Recordings
Search:
Navigator Search:
Have you written tests?
[Optional] Description