Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix discounts #207

Merged
merged 6 commits into from
Oct 16, 2019
Merged

Fix discounts #207

merged 6 commits into from
Oct 16, 2019

Conversation

dominik-zeglen
Copy link
Contributor

@dominik-zeglen dominik-zeglen commented Oct 10, 2019

I want to merge this change because it fixes sale dates and updates design.
Resolves #69

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@dominik-zeglen dominik-zeglen changed the title Fix/sales Fix discounts Oct 11, 2019
@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #207 into master will increase coverage by 0.06%.
The diff coverage is 95.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
+ Coverage    73.5%   73.57%   +0.06%     
==========================================
  Files         567      569       +2     
  Lines        5919     5942      +23     
  Branches     1007     1008       +1     
==========================================
+ Hits         4351     4372      +21     
  Misses       1394     1394              
- Partials      174      176       +2
Impacted Files Coverage Δ
...ariantCreateDialog/ProductVariantCreateSummary.tsx 85.71% <ø> (ø) ⬆️
src/theme.ts 100% <ø> (ø) ⬆️
...mponents/VoucherDetailsPage/VoucherDetailsPage.tsx 71.42% <ø> (ø) ⬆️
...ounts/components/SaleCreatePage/SaleCreatePage.tsx 100% <ø> (ø) ⬆️
...nts/components/SaleDetailsPage/SaleDetailsPage.tsx 92.3% <100%> (+1%) ⬆️
src/discounts/components/SaleValue/SaleValue.tsx 100% <100%> (ø)
src/discounts/components/SaleType/SaleType.tsx 100% <100%> (ø)
...onents/VoucherRequirements/VoucherRequirements.tsx 88.88% <100%> (+1.38%) ⬆️
...VariantCreateDialog/ProductVariantCreatePrices.tsx 63.15% <100%> (ø) ⬆️
...discounts/components/VoucherValue/VoucherValue.tsx 90.9% <100%> (+5.19%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b5b973...e6dbd3a. Read the comment docs.

@maarcingebala maarcingebala merged commit 47dc872 into master Oct 16, 2019
@maarcingebala maarcingebala deleted the fix/sales branch October 16, 2019 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when creating sales on Dashboard 2.0
3 participants