Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service account section #188

Merged
merged 20 commits into from
Oct 8, 2019
Merged

Add service account section #188

merged 20 commits into from
Oct 8, 2019

Conversation

dominik-zeglen
Copy link
Contributor

@dominik-zeglen dominik-zeglen commented Sep 30, 2019

I want to merge this change because it implements service account section allowing users to add bots 🤖

Screenshots

Screenshot 2019-09-30 at 12 34 02

Screenshot 2019-09-30 at 12 35 17

Screenshot 2019-09-30 at 12 35 23

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@dominik-zeglen dominik-zeglen marked this pull request as ready for review September 30, 2019 16:49
@codecov
Copy link

codecov bot commented Sep 30, 2019

Codecov Report

Merging #188 into master will increase coverage by 0.24%.
The diff coverage is 81.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage    73.3%   73.54%   +0.24%     
==========================================
  Files         538      556      +18     
  Lines        5472     5624     +152     
  Branches      947      962      +15     
==========================================
+ Hits         4011     4136     +125     
- Misses       1296     1322      +26     
- Partials      165      166       +1
Impacted Files Coverage Δ
src/components/Shop/query.ts 100% <ø> (ø) ⬆️
src/components/AccountStatus/AccountStatus.tsx 100% <ø> (ø)
src/staff/fixtures.ts 100% <ø> (ø) ⬆️
...f/components/StaffDetailsPage/StaffDetailsPage.tsx 100% <ø> (ø) ⬆️
src/intl.ts 100% <ø> (ø) ⬆️
src/storybook/stories/staff/StaffDetailsPage.tsx 54.54% <ø> (ø) ⬆️
src/configuration/index.tsx 37.5% <ø> (ø) ⬆️
...mponents/AccountPermissions/AccountPermissions.tsx 61.11% <100%> (ø)
src/icons/Bot.tsx 100% <100%> (ø)
...ces/components/ServiceListPage/ServiceListPage.tsx 100% <100%> (ø)
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1be6d8a...d16227c. Read the comment docs.

@maarcingebala
Copy link
Member

maarcingebala commented Oct 3, 2019

Account's permissions are not loaded, I can only select "full permissions" option:
image

Edit: Nevermind, I don't know what I did but now it's loading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants