-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sorting to product list #173
Conversation
5fd5ab1
to
4a18820
Compare
Codecov Report
@@ Coverage Diff @@
## master #173 +/- ##
==========================================
- Coverage 73.52% 73.33% -0.19%
==========================================
Files 534 538 +4
Lines 5397 5445 +48
Branches 924 940 +16
==========================================
+ Hits 3968 3993 +25
- Misses 1273 1289 +16
- Partials 156 163 +7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Hover state is missing
- I am not sure sorting by name on default is a good idea
After speaking to @maarcingebala we agreed to keep sorting by name as a default sort field. |
08d2858
to
4709291
Compare
I want to merge this change because it adds sorting prototype to product list.
Screenshots
Pull Request Checklist
.pot
file.