Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sorting to product list #173

Merged
merged 14 commits into from
Sep 16, 2019
Merged

Add sorting to product list #173

merged 14 commits into from
Sep 16, 2019

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it adds sorting prototype to product list.

Screenshots

Screenshot 2019-09-13 at 16 47 49

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Sep 16, 2019

Codecov Report

Merging #173 into master will decrease coverage by 0.18%.
The diff coverage is 54.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
- Coverage   73.52%   73.33%   -0.19%     
==========================================
  Files         534      538       +4     
  Lines        5397     5445      +48     
  Branches      924      940      +16     
==========================================
+ Hits         3968     3993      +25     
- Misses       1273     1289      +16     
- Partials      156      163       +7
Impacted Files Coverage Δ
src/icons/Pages.tsx 100% <ø> (ø) ⬆️
...cts/components/ProductListPage/ProductListPage.tsx 90.9% <ø> (ø) ⬆️
src/icons/StaffMembers.tsx 100% <ø> (ø) ⬆️
src/icons/Sales.tsx 100% <ø> (ø) ⬆️
src/icons/Navigation.tsx 100% <ø> (ø) ⬆️
src/icons/ProductTypes.tsx 100% <ø> (ø) ⬆️
src/icons/SiteSettings.tsx 100% <ø> (ø) ⬆️
src/icons/Orders.tsx 100% <ø> (ø) ⬆️
src/icons/ShippingMethods.tsx 100% <ø> (ø) ⬆️
src/products/urls.ts 61.9% <ø> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b0f293...cd6940a. Read the comment docs.

Copy link
Contributor

@benekex2 benekex2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Hover state is missing
  • I am not sure sorting by name on default is a good idea

@dominik-zeglen
Copy link
Contributor Author

After speaking to @maarcingebala we agreed to keep sorting by name as a default sort field.

@dominik-zeglen dominik-zeglen merged commit 596e93a into master Sep 16, 2019
@dominik-zeglen dominik-zeglen deleted the add/product-sorting branch September 16, 2019 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants