Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI improvements #166

Merged
merged 65 commits into from
Sep 16, 2019
Merged

UI improvements #166

merged 65 commits into from
Sep 16, 2019

Conversation

benekex2
Copy link
Contributor

@benekex2 benekex2 commented Sep 11, 2019

Closes #101
Closes #132
Closes #120

Screenshots

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Sep 11, 2019

Codecov Report

Merging #166 into master will decrease coverage by 0.13%.
The diff coverage is 70.58%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #166      +/-   ##
=========================================
- Coverage   73.74%   73.6%   -0.14%     
=========================================
  Files         528     531       +3     
  Lines        5328    5342      +14     
  Branches      911     917       +6     
=========================================
+ Hits         3929    3932       +3     
- Misses       1254    1259       +5     
- Partials      145     151       +6
Impacted Files Coverage Δ
...ts/OrderProductAddDialog/OrderProductAddDialog.tsx 63.88% <ø> (ø) ⬆️
...pleteSelectField/SingleAutocompleteSelectField.tsx 50% <ø> (ø) ⬆️
src/components/Checkbox/Checkbox.tsx 75% <ø> (ø) ⬆️
...onents/AttributeProperties/AttributeProperties.tsx 100% <ø> (ø) ⬆️
src/components/RadioGroupField/RadioGroupField.tsx 87.5% <ø> (ø) ⬆️
...rc/orders/components/OrderHistory/OrderHistory.tsx 32.5% <ø> (ø) ⬆️
...mponents/CollectionListPage/CollectionListPage.tsx 100% <ø> (ø) ⬆️
src/components/Theme/ThemeProvider.tsx 61.53% <ø> (ø) ⬆️
...ponents/TablePagination/TablePaginationActions.tsx 75% <ø> (ø) ⬆️
...mponents/OrderDraftListPage/OrderDraftListPage.tsx 100% <ø> (ø) ⬆️
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9503c88...6063048. Read the comment docs.

Copy link
Contributor

@dominik-zeglen dominik-zeglen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure that important in src/theme.ts are overused and those styles can be written without abusing this tag.

Additionally:
Screenshot 2019-09-11 at 15 02 00
Margin between header and line is definitely too big

Screenshot 2019-09-11 at 15 04 05

Bottom borders should be soft too

Screenshot 2019-09-11 at 15 04 56

Screenshot 2019-09-11 at 15 05 02

The first one is focused, and second unfocused. I think it should be done the other way. There should be some margin between checkbox and label

Screenshot 2019-09-11 at 15 07 27

Screenshot 2019-09-11 at 15 09 42

Text shouldn't be gray when hovered or focused, at least not in dark mode

Screenshot 2019-09-11 at 15 12 00

Labels should not be seen through other components

Screenshot 2019-09-11 at 15 13 12

Bottom padding should be decreased

src/products/views/ProductCreate.tsx Outdated Show resolved Hide resolved
src/products/views/ProductUpdate/handlers.ts Outdated Show resolved Hide resolved
src/theme.ts Show resolved Hide resolved
src/theme.ts Show resolved Hide resolved
@maarcingebala
Copy link
Member

maarcingebala commented Sep 12, 2019

  • Typo in Attribute details view - should be "If enabled"

image

@dominik-zeglen dominik-zeglen merged commit d897ea4 into master Sep 16, 2019
@dominik-zeglen dominik-zeglen deleted the ui-improvements branch September 16, 2019 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change naming of buttons Remove address title from address cards UI improvements #4
3 participants