Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback locale #153

Merged
merged 2 commits into from
Sep 4, 2019
Merged

Add fallback locale #153

merged 2 commits into from
Sep 4, 2019

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it fixes some bugs causing locale to be undefined, which would make <DateTime /> components explode.

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Sep 4, 2019

Codecov Report

Merging #153 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
- Coverage   74.45%   74.44%   -0.02%     
==========================================
  Files         507      507              
  Lines        5062     5063       +1     
  Branches      866      867       +1     
==========================================
  Hits         3769     3769              
- Misses       1153     1154       +1     
  Partials      140      140
Impacted Files Coverage Δ
src/components/Locale/Locale.tsx 33.33% <0%> (-2.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 192c67b...3601236. Read the comment docs.

@maarcingebala maarcingebala merged commit 0768591 into master Sep 4, 2019
@maarcingebala maarcingebala deleted the fix/exploding-locales branch September 4, 2019 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants