Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tc tags for e2e tests #134

Merged
merged 3 commits into from
Aug 28, 2019
Merged

Add tc tags for e2e tests #134

merged 3 commits into from
Aug 28, 2019

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it allows grabbing DOM elements and interacting with them by test-cafe.

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Number of API calls is optimized.
  4. The changes are tested.
  5. Type definitions are up to date.
  6. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

Merging #134 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
+ Coverage   88.09%   88.09%   +<.01%     
==========================================
  Files         703      703              
  Lines       11055    11058       +3     
  Branches      927      928       +1     
==========================================
+ Hits         9739     9742       +3     
  Misses       1161     1161              
  Partials      155      155
Impacted Files Coverage Δ
src/components/messages/MessageManager.tsx 62.06% <ø> (ø) ⬆️
...components/ProductAttributes/ProductAttributes.tsx 93.18% <ø> (ø) ⬆️
...onents/ProductOrganization/ProductOrganization.tsx 100% <ø> (ø) ⬆️
...ductVariantAttributes/ProductVariantAttributes.tsx 93.1% <ø> (ø) ⬆️
...ponents/TablePagination/TablePaginationActions.tsx 92.59% <ø> (ø) ⬆️
src/auth/components/LoginPage/LoginPage.tsx 96% <ø> (ø) ⬆️
src/components/ImageTile/ImageTile.tsx 92.3% <ø> (ø) ⬆️
...roducts/components/ProductImages/ProductImages.tsx 90.69% <ø> (ø) ⬆️
src/components/SaveButtonBar/SaveButtonBar.tsx 82.35% <ø> (ø) ⬆️
...cts/components/ProductListPage/ProductListPage.tsx 93.18% <ø> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ec7508...ea82be8. Read the comment docs.

@maarcingebala maarcingebala merged commit ab68b39 into master Aug 28, 2019
@maarcingebala maarcingebala deleted the add/tc-tags branch August 28, 2019 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants