Fix app configuration frame embedding #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominik-zeglen
requested review from
a team,
kamilpastuszka and
SektorDV
and removed request for
a team
github-actions
bot
temporarily deployed
to
storybook fix-app-config-embedding
jwm0
suggested changes
Jun 17, 2021
| }; | ||
| } | ||
|
|
||
| async function _fetchAndSetContent( |
There was a problem hiding this comment.
I don't think we need to prefix this with _ as we're not exporting it anywhere
| } | ||
|
|
||
| async function _fetchAndSetContent( | ||
| frameContainer: MutableRefObject<HTMLDivElement>, |
There was a problem hiding this comment.
Let's pass the object reference itself without any React logic
Suggested change
| frameContainer: MutableRefObject<HTMLDivElement>, | |
| frameContainer: HTMLDivElement, |
There was a problem hiding this comment.
Im not so sure if it would work, this object has to be mutable. Ill test it tomorrow
There was a problem hiding this comment.
Suprisingly it works
| const frameContainer = useRef<HTMLDivElement>(null); | ||
|
|
||
| useEffect(() => { | ||
| _fetchAndSetContent(frameContainer, data, backendHost, callbacks); |
There was a problem hiding this comment.
Suggested change
| _fetchAndSetContent(frameContainer, data, backendHost, callbacks); | |
| _fetchAndSetContent(frameContainer.current, data, backendHost, callbacks); |
bmigirl
approved these changes
Jun 17, 2021
jwm0
approved these changes
Jun 18, 2021
SektorDV
approved these changes
Jun 18, 2021
kamilpastuszka
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this change because it fixes problems with iframe scripts embedding - it currently handles cases when configuration page has no
<script />tags at all or when they don't havesrcproperty. Also fixes relative path handling.PR intended to be tested with API branch: master
Pull Request Checklist
[data-test-id]are added for new elementsTest environment config
API_URI=https://qa.staging.saleor.cloud/graphql/