Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change rateType from enum to string #1121

Merged
merged 6 commits into from
May 24, 2021
Merged

Change rateType from enum to string #1121

merged 6 commits into from
May 24, 2021

Conversation

jwm0
Copy link
Contributor

@jwm0 jwm0 commented May 18, 2021 •
edited
Loading

I want to merge this change because it changes rateType from enum to string.

PR intended to be tested with API branch: fix/handle-vatlayer-changes-in-returned-tax-types

Screenshots

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes [data-test-id] are added for new elements
  4. Changes are mentioned in the changelog
  5. The changes are tested in different browsers and in light/dark mode

Test environment config

API_URI=https://qa.staging.saleor.cloud/graphql/

@jwm0 jwm0 requested review from korycins, eCzerniak, a team, orzechdev and bmigirl and removed request for a team May 18, 2021 15:38
@patrys
Copy link
Member

patrys commented May 18, 2021

Task linked: SALEOR-3406 Change TaxRateType from Enum to String

@jwm0 jwm0 removed the request for review from bmigirl May 18, 2021 15:38
@github-actions github-actions bot temporarily deployed to saleor-3406-change-taxratetype-enum-to-string May 18, 2021 15:39 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-3406-change-taxratetype-enum-to-string May 18, 2021 15:39 Inactive
@github-actions github-actions bot temporarily deployed to saleor-3406-change-taxratetype-enum-to-string May 18, 2021 16:21 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-3406-change-taxratetype-enum-to-string May 18, 2021 16:21 Inactive
@korycins korycins mentioned this pull request May 20, 2021
Merged
11 tasks
@github-actions github-actions bot temporarily deployed to saleor-3406-change-taxratetype-enum-to-string May 24, 2021 07:42 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-3406-change-taxratetype-enum-to-string May 24, 2021 07:42 Inactive
@github-actions github-actions bot temporarily deployed to saleor-3406-change-taxratetype-enum-to-string May 24, 2021 11:22 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-3406-change-taxratetype-enum-to-string May 24, 2021 11:22 Inactive
@github-actions github-actions bot temporarily deployed to saleor-3406-change-taxratetype-enum-to-string May 24, 2021 11:51 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-3406-change-taxratetype-enum-to-string May 24, 2021 11:51 Inactive
@github-actions github-actions bot temporarily deployed to saleor-3406-change-taxratetype-enum-to-string May 24, 2021 13:30 Inactive
@jwm0 jwm0 merged commit 5ace78f into master May 24, 2021
@jwm0 jwm0 deleted the SALEOR-3406-change-taxratetype-enum-to-string branch May 24, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orzechdev orzechdev orzechdev approved these changes

@korycins korycins korycins approved these changes

@eCzerniak eCzerniak eCzerniak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jwm0 @patrys @orzechdev @korycins @eCzerniak