Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SALEOR 3115 Fix EditorJS inline formatting #1096

Merged
merged 2 commits into from
May 7, 2021

Conversation

orzechdev
Copy link
Contributor

@orzechdev orzechdev commented May 6, 2021

I want to merge this change because... it fixes inline formatting in rich text editors - it was impossible to save bold, italic, link and strikethrough.

PR intended to be tested with API branch: master

Screenshots

Zrzut ekranu 2021-05-6 o 18 28 59

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes [data-test-id] are added for new elements
  4. Changes are mentioned in the changelog
  5. The changes are tested in different browsers and in light/dark mode

Test environment config

API_URI=https://qa.staging.saleor.cloud/graphql/

@github-actions github-actions bot temporarily deployed to saleor-3115-fix-editorjs-inline-formatting May 6, 2021 16:24 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-3115-fix-editorjs-inline-formatting May 6, 2021 16:24 Inactive
@github-actions github-actions bot temporarily deployed to saleor-3115-fix-editorjs-inline-formatting May 6, 2021 16:27 Inactive
@patrys
Copy link
Member

patrys commented May 6, 2021

@orzechdev orzechdev marked this pull request as ready for review May 6, 2021 16:58
@orzechdev orzechdev requested review from a team, dominik-zeglen and jwm0 and removed request for a team May 6, 2021 16:58
@github-actions github-actions bot requested a review from pwgryglak May 6, 2021 16:58
@eCzerniak eCzerniak self-requested a review May 7, 2021 07:19
@github-actions github-actions bot removed the request for review from pwgryglak May 7, 2021 07:49
@jwm0 jwm0 merged commit 5a43917 into master May 7, 2021
@jwm0 jwm0 deleted the SALEOR-3115-fix-editorjs-inline-formatting branch May 7, 2021 08:06
jwm0 pushed a commit that referenced this pull request May 7, 2021
* Fix EditorJS inline formatting

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants