Show LO confirmation alert based on toggle in Call Visualizer #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasmustautsglia
requested review from
igorkravchenko,
gersonnoboa,
EgorovEI and
yurii-glia
EgorovEI
approved these changes
Nov 2, 2023
|
Could it be covered with unit tests? |
|
After many attempts, I could not find a reasonable way to test this. The reason is that I need to test if, depending on the site settings, the alert is shown. However, the way CallVisualizer Coordinator is set up, I didn't find a way to check it. |
yurii-glia
approved these changes
Nov 2, 2023
|
!squash |
This PR displays Live Observation confirmation alert based on site settings MOB-2811
sm-deployer
force-pushed
the
Show-LO-confirmation-alert-based-on-toggle-in-Call-Visualizer
branch
from
c252827 to
6ec7424
Compare
rasmustautsglia
deleted the
Show-LO-confirmation-alert-based-on-toggle-in-Call-Visualizer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue:
https://glia.atlassian.net/browse/MOB-2811
What was solved?
This PR displays Live Observation confirmation alert based on site settings
Release notes:
Additional info:
Screenshots: