-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore Video Call Visualizer on enqueuing if it is running #1189
base: feature/entry-widget-and-secure-conversations-v2
Are you sure you want to change the base?
Restore Video Call Visualizer on enqueuing if it is running #1189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the added logic I see that if there is ongoing CV without video and resolveEngagementState
is called, snackbar will not be shown. But our diagrams requires this. But maybe I missed something.
It would also be good to add unit test for showing snackbar in this case. If it is not added yet.
@EgorovEI It seems that it's either restoring Video or snackbar. ios-sdk-widgets/GliaWidgetsTests/Sources/Glia/GliaTests+EngagementLauncher.swift Line 118 in 86d4e1b
|
|
192a4bd
to
505d157
Compare
505d157
to
7e9fc2f
Compare
7e9fc2f
to
ae8cb19
Compare
@EgorovEI basically was right that there is an issue with restoring non video CV engagement with video engagement type selected. During fixing this issue I decided to add a test for every restoring CV engagement case(audio, chat, video engagement) it may be a bit redundant but will keep us safe as there is different behavior for video and non-video engagements. Thanks Egor! |
) | ||
throw GliaError.callVisualizerEngagementExists |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As Android team does not throw error here and it there is no sense to do it we decided to align it between platforms.
engagement: Engagement, | ||
snackBarStyle: Theme.SnackBarStyle | ||
) { | ||
if engagementKind == .videoCall && engagement.mediaStreams.video != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not come up with better solution so these checks happen twice: here and in Call Visualizer. It has to be done inside Call Visualizer as it is internal method and may be used somewhere else.
What was solved?
This PR restores Video Call Visualizer on enqueuing if it is running
Release notes:
Additional info: