Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CONTRIBUTING.md #734

Merged
merged 5 commits into from
Jan 5, 2019
Merged

add CONTRIBUTING.md #734

merged 5 commits into from
Jan 5, 2019

Conversation

KageShiron
Copy link
Member

@KageShiron KageShiron commented Dec 29, 2018 •
edited
Loading

sakura-editor/management-forum#56
sakura-editor/management-forum#57

  • 初心者も大歓迎だよ！
  • Wiki見てね！
  • 何も宣言しなければzlib Licenseとして受け取るよ！

の3つを宣言したCONTRIBUTING.mdを作ってみました。内容のご指摘は絶賛受付中です。

@KageShiron KageShiron mentioned this pull request Dec 29, 2018
Open
beru
beru reviewed Dec 29, 2018
View reviewed changes
CONRTIBUTING.md Outdated Show resolved Hide resolved
beru
beru reviewed Dec 29, 2018
View reviewed changes
CONRTIBUTING.md Outdated Show resolved Hide resolved
beru
beru previously approved these changes Dec 29, 2018
View reviewed changes
Copy link
Contributor

@beru beru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

問題無いかと思います。

@berryzplus
Copy link
Contributor

対応ありがとうございます。
これで issue や pull-request の上に説明が表示されるようになるわけですね。 > sakura-editor/management-forum#56 (comment)
わくわく・・・ 😄

berryzplus
berryzplus previously approved these changes Dec 30, 2018
View reviewed changes
Copy link
Contributor

@berryzplus berryzplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正確認しました。この対応に関して問題なさそうです。

m-tmatma
m-tmatma previously requested changes Dec 30, 2018
View reviewed changes
CONRTIBUTING.md Outdated Show resolved Hide resolved
@m-tmatma m-tmatma dismissed their stale review December 30, 2018 06:44

修正を確認しました。

@m-tmatma
Copy link
Member

sakura-editor/sakura-editor.github.io#46
に依存しているのでそちらを優先ですね。

m-tmatma
m-tmatma previously approved these changes Dec 30, 2018
View reviewed changes
@m-tmatma
Copy link
Member

この PR は markdown だけの修正で appveyor ビルドは不要なので
https://qiita.com/vmmhypervisor/items/f10c77a375c2a663b300
のように [ci skip] とコミットログに書けば ci ビルドをスキップしてくれます。

※ 結構指定し忘れることがありますが。

beru
beru previously requested changes Jan 3, 2019
View reviewed changes
Copy link
Contributor

@beru beru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

綴りミスの修正をお願いします。

現在このPRのタイトルが、add CONTRBUTING.md となっていますが、T と R の間の I が抜けています。正しくは、add CONTRIBUTING.md だと思います。

また追加されたファイルの名前が、CONRTIBUTING.md となっていますが R と T の順序が入れ替わっています。正しくは、CONTRIBUTING.md な筈です。

@KageShiron
Copy link
Member Author

KageShiron commented Jan 3, 2019 •
edited
Loading

ぎゃあ、本当だ
(そして[ci skip]つけ忘れた・・・)

コミットメッセージはスカッシュマージするときに書き換えますね

@m-tmatma m-tmatma added this to the next release milestone Jan 3, 2019
@m-tmatma m-tmatma added the document ドキュメント label Jan 3, 2019
@beru beru changed the title add CONTRBUTING.md add CONTRIBUTING.md Jan 5, 2019
beru
beru reviewed Jan 5, 2019
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
beru
beru reviewed Jan 5, 2019
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@beru beru dismissed their stale review January 5, 2019 00:36

綴りミスが修正された為

@KageShiron
Copy link
Member Author

用語などを微修正しました。
(そして、ci skipはまたつけ忘れました・・・)

beru
beru approved these changes Jan 5, 2019
View reviewed changes
Copy link
Contributor

@beru beru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

問題無いと思います。

@KageShiron KageShiron merged commit 481369a into sakura-editor:master Jan 5, 2019
@KageShiron KageShiron deleted the add/CONTRIBUTING branch January 5, 2019 05:28
@KageShiron
Copy link
Member Author

そして、スカッシュマージし忘れるという(まぁ、いいか)

@berryzplus
Copy link
Contributor

そして、PRのタイトルも直ってなかったというネタに気付く（まぁ、いいか:smile:

@berryzplus
Copy link
Contributor

直ってた！

@KageShiron
Copy link
Member Author

beruさんがこっそり直してくれました^^

HoppingTappy pushed a commit to HoppingTappy/sakura that referenced this pull request Jun 11, 2019
@KageShiron
Merge pull request sakura-editor#734 from KageShiron/add/CONTRIBUTING
1c581b8 
add CONTRIBUTING.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KENCHjp KENCHjp KENCHjp left review comments

@beru beru beru approved these changes

@m-tmatma m-tmatma m-tmatma left review comments

@berryzplus berryzplus berryzplus left review comments

Assignees
No one assigned
Labels
document ドキュメント
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@KageShiron @berryzplus @m-tmatma @beru @KENCHjp