Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doxygen コメントの @file をつける #535

Merged

Conversation

m-tmatma
Copy link
Member

@m-tmatma m-tmatma commented Oct 8, 2018

doxygen コメントの @file をつける

@m-tmatma m-tmatma added the document ドキュメント label Oct 8, 2018
@m-tmatma m-tmatma added this to the next release milestone Oct 8, 2018
@m-tmatma
Copy link
Member Author

m-tmatma commented Oct 8, 2018

変更前: https://ci.appveyor.com/project/m-tmatma/sakura/builds/19319575
変更後: https://ci.appveyor.com/project/m-tmatma/sakura/builds/19331151

※ asm 部分のコメント部分で行番号の部分がずれているので以下のようなバッチファイルで
コメント部分をカットして比較すると楽です。(カレントディレクトリ以下の asm ファイルで
先頭が ; で始まる行を取り除きます。

"C:\Program Files\Git\usr\bin\find.exe" . -name "*.asm" -exec "C:\Program Files\Git\usr\bin\sed.exe" -i 's/^^;.*//g' {} ;

cutcomment.txt

addDoxygenFileComment.py Outdated Show resolved Hide resolved
addDoxygenFileComment.py Outdated Show resolved Hide resolved
Copy link
Contributor

@berryzplus berryzplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです。

対応内容を眺めた感じ、特に問題は見当たりませんでした。
指摘への対応も終わっているようなので代わりにLGTM出しときます。
ドキュメント系の変更なので何かあれば適宜対処、ということで柔軟にいきたいです。

@m-tmatma m-tmatma merged commit b95cedf into sakura-editor:master Oct 15, 2018
HoppingTappy pushed a commit to HoppingTappy/sakura that referenced this pull request Jun 11, 2019
…n-file-comment

doxygen コメントの @file をつける
@m-tmatma m-tmatma deleted the feature/add-doxygen-file-comment branch July 5, 2019 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document ドキュメント
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants