CEditView::Create において SystemParametersInfo 呼び出しが失敗した場合の対策を追加 #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
失敗した場合の値は上限の 31 にしました。マジックナンバーではなくて constexpr で定数宣言した方が良いかも知れませんが…。 |
m-tmatma
reviewed
Oct 7, 2018
| @@ -385,7 +385,12 @@ BOOL CEditView::Create( | |||
|
|
|||
| /* キーボードの現在のリピート間隔を取得 */ | |||
| DWORD dwKeyBoardSpeed; | |||
There was a problem hiding this comment.
- dwKeyBoardSpeed のデフォルトは const の変数として定義した方がいいと思います。
- 392行目では直値を使わず、その定義した const の変数を使った方がいいと思います。
There was a problem hiding this comment.
8927c9b で、直値を何度も使わずに定数宣言して使うように修正しました。
m-tmatma
reviewed
Oct 7, 2018
sakura_core/view/CEditView.cpp
Outdated
| } | ||
| else{ | ||
| dwKeyBoardSpeed = 31; | ||
| dwKeyBoardSpeed = keyboardRepeatSpeedMax; |
There was a problem hiding this comment.
細かいですが、
393行目は意味的には最大値ではなくデフォルト値という意味なので
390行目と396行目は役割が異なります。
別の定数を用意してそれを393行目で使って、その上でその定義値として、keyboardRepeatSpeedMax を使えばいいと思います。
|
Merge します。もし問題が見つかったら別の PR で対処する事にしましょう。 |
HoppingTappy
pushed a commit
to HoppingTappy/sakura
that referenced
this pull request
Jun 11, 2019
…ix_episode_2 CEditView::Create において SystemParametersInfo 呼び出しが失敗した場合の対策を追加
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#523 で頂いた レビュー指摘コメント に対応しました。