Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse-buildlog.py での不要なログを削除 #507

Conversation

m-tmatma
Copy link
Member

parse-buildlog.py での不要なログを削除

parse-buildlog.py から以下の流れで無駄なログが出力されるので削除する

(blobURL, relpath) = appveyor.getBlobURLWithLine(path, lineNumber)

sakura/appveyor_env.py

Lines 161 to 162 in d0e7c5d

def getBlobURLWithLine(self, path, startLine):
(blobURL, relpath) = self.getBlobURL(path)

sakura/appveyor_env.py

Lines 146 to 154 in d0e7c5d

def getBlobURL(self, path):
if "APPVEYOR_BUILD_FOLDER" in self.env:
relpath = os.path.relpath(path, self.env["APPVEYOR_BUILD_FOLDER"])
else:
relpath = path
relpath = self.convertRealPath(relpath)
print (relpath)
relpath = relpath.replace('\\', '/')

@m-tmatma m-tmatma added this to the next release milestone Sep 30, 2018
Copy link
Contributor

@berryzplus berryzplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです。

スクリプト動作確認用の出力と思いますので要らなくなったなら削って大丈夫だと思います。

@m-tmatma
Copy link
Member Author

m-tmatma commented Oct 3, 2018

#514 の解決後にマージ予定

@m-tmatma
Copy link
Member Author

m-tmatma commented Oct 3, 2018

master のビルド通ったので (#514) マージします。

@m-tmatma m-tmatma merged commit dbbbfc9 into sakura-editor:master Oct 3, 2018
@m-tmatma m-tmatma deleted the feature/remove-verbose-log-in-parselog branch October 3, 2018 22:13
HoppingTappy pushed a commit to HoppingTappy/sakura that referenced this pull request Jun 11, 2019
…bose-log-in-parselog

parse-buildlog.py での不要なログを削除
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants