Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve unavailable Oniguruma URL #1859

Merged
merged 1 commit into from
Jul 7, 2022
Merged

resolve unavailable Oniguruma URL #1859

merged 1 commit into from
Jul 7, 2022

Conversation

dAu6jARL
Copy link
Contributor

@dAu6jARL dAu6jARL commented Jul 3, 2022 •
edited
Loading

change URL http://www.geocities.jp/kosako3/oniguruma to https://github.com/kkos/oniguruma

PR の目的

  • 存在しない鬼車URLリンクの修正

カテゴリ

@AppVeyorBot
Copy link

✅ Build sakura 1.0.4165 completed (commit 08c3076b57 by @dAu6jARL)

@sonarcloud
Copy link

sonarcloud bot commented Jul 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

beru
beru approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@beru beru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

見た感じ問題無いと思います！

@berryzplus
Copy link
Contributor

関連
sakura-editor/sakura-editor.github.io#49

berryzplus
berryzplus approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@berryzplus berryzplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

リンク切れ報告ありがとうございます。

目的
存在しない鬼車URLリンクの修正

Wikipedia等でも同一人物によるサイトとみなされてるようなので問題なさそうに思います。
なお、サクラエディタの正規表現ライブラリは「鬼雲」に基づいています。
「鬼雲」は「鬼車」の改造ライブラリですが、概念は共通すると思われます。（私見）

カテゴリ
不具合修正

サクラエディタの挙動には影響しない修正は、不具合修正としたくない気がします。
「ドキュメント修正」とするのがより適切かと思います。

@berryzplus berryzplus added the document ドキュメント label Jul 7, 2022
@beru beru merged commit 38b5c50 into sakura-editor:master Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berryzplus berryzplus berryzplus approved these changes

@beru beru beru approved these changes

Assignees
No one assigned
Labels
document ドキュメント
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dAu6jARL @AppVeyorBot @berryzplus @beru