StdAfx.h に定義されている malloc と GlobalLock の型変換マクロを削除する #1842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build sakura 1.0.4128 completed (commit 06bf6b6400 by @k-kagari) |
|
Kudos, SonarCloud Quality Gate passed! |
berryzplus
approved these changes
May 7, 2022
|
承認ありがとうございます。マージします。 |
|
この修正（≒冗長なマクロの定義を削除したい）については特にコメント不要でLGTMです。 |
|
あえて耳に入れておきたいのですが、「Cスタイルキャストじゃないの？」というようなお話ですか？😛 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR の目的
現在 StdAfx.h には malloc と GlobalLock にキャストを付加するマクロが計5つ定義されています。コード中におけるマクロの存在は開発作業を複雑化させるため、特に意義のないこれらのマクロを削除したいと思います。
カテゴリ
仕様・動作説明
以下のマクロを削除します。
関連 issue, PR
#1800