sakura.iss を UTF8 に変更 #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sakura.iss 自体の文字コード以外のファイル内容の一致も確認。
|
インストーラのバイナリって完全一致するものです？ 以下は AppVeyor のバイナリを比較してみた結果です。
タイムスタンプとか何かしらの動的なものが埋め込まれる都合で、このように diff が出るのは仕方ないと思っていたのですが。 |
|
バイナリ差分はさておきインストーラ実行時の日本語文言は正しく表示されているようなので LGTM です。
|
appveyor のビルドでは EXE 等のリビルドが走るし、GitHash が異なるので違いますが |
|
なるほどど。また新しい知識が増えました。ありがとうございます！ |
Closed
HoppingTappy
pushed a commit
to HoppingTappy/sakura
that referenced
this pull request
Jun 11, 2019
…-utf8 sakura.iss を UTF8 に変更
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#132: sakura.iss を UTF8 に変更
sakura.iss の文字コード変換前後で(ローカルビルドの)インストーラの
バイナリが完全一致しているのを確認した。