Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solution のビルドをバッチファイルの中で行う #163

Merged
merged 2 commits into from
Jun 23, 2018
Merged

solution のビルドをバッチファイルの中で行う #163

merged 2 commits into from
Jun 23, 2018

Conversation

m-tmatma
Copy link
Member

#154: solution のビルドをバッチファイルの中で行う

  • appveyor.yml でやらずに別のバッチでやることによりメンテしやすくなる
  • ローカルでテストしやすくなる。

@m-tmatma m-tmatma added refactoring リファクタリング 【ChangeLog除外】 CI appveyor など CI 関連 【ChangeLog除外】 labels Jun 22, 2018
@m-tmatma m-tmatma added this to the next release milestone Jun 22, 2018
@m-tmatma m-tmatma mentioned this pull request Jun 22, 2018
Merged
@m-tmatma m-tmatma mentioned this pull request Jun 23, 2018
Closed
berryzplus
berryzplus approved these changes Jun 23, 2018
View reviewed changes
Copy link
Contributor

@berryzplus berryzplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです。

@m-tmatma m-tmatma merged commit 6660f3e into sakura-editor:master Jun 23, 2018
@m-tmatma m-tmatma deleted the feature/refactor-build-solution branch June 23, 2018 05:39
m-tmatma added a commit to m-tmatma/sakura that referenced this pull request Jun 23, 2018
@m-tmatma
sakura-editor#163: solution のビルド用のバッチファイル修正
12f758e 
(appveyor.yml でソリューション名を定義せず build-sln.bat 側で行う)
@m-tmatma m-tmatma mentioned this pull request Jun 23, 2018
Merged
m-tmatma added a commit that referenced this pull request Jun 23, 2018
@m-tmatma
#163: solution のビルド用のバッチファイル修正
1fccc66 
(appveyor.yml でソリューション名を定義せず build-sln.bat 側で行う)
@m-tmatma m-tmatma mentioned this pull request Jun 27, 2018
Closed
berryzplus pushed a commit to berryzplus/sakura-editor that referenced this pull request Jul 5, 2018
@m-tmatma @berryzplus
sakura-editor#163: solution のビルド用のバッチファイル修正
0ad1d4e 
(appveyor.yml でソリューション名を定義せず build-sln.bat 側で行う)
@ds14050 ds14050 added refactoring リファクタリング 【ChangeLog除外】 CI appveyor など CI 関連 【ChangeLog除外】 labels Sep 18, 2018
HoppingTappy pushed a commit to HoppingTappy/sakura that referenced this pull request Jun 11, 2019
@m-tmatma
Merge pull request sakura-editor#163 from m-tmatma/feature/refactor-b…
201a3a3 
…uild-solution

solution のビルドをバッチファイルの中で行う
HoppingTappy pushed a commit to HoppingTappy/sakura that referenced this pull request Jun 11, 2019
@m-tmatma
sakura-editor#163: solution のビルド用のバッチファイル修正
b777a5f 
(appveyor.yml でソリューション名を定義せず build-sln.bat 側で行う)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berryzplus berryzplus berryzplus approved these changes

Assignees
No one assigned
Labels
CI appveyor など CI 関連 【ChangeLog除外】 refactoring リファクタリング 【ChangeLog除外】
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@m-tmatma @berryzplus @ds14050