Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CTextMetrics のコードを整理する #1547

Merged
merged 1 commit into from
Feb 21, 2021
Merged

CTextMetrics のコードを整理する #1547

merged 1 commit into from
Feb 21, 2021

Conversation

kengoide
Copy link
Member

PR の目的

CTextMetrics から実行されないコード等を消去し、同時に SonarCloud の警告に対応します。

カテゴリ

  • リファクタリング

PR のメリット

  • SonarCloud の警告が減少します。
  • コード量を削減できます。

関連 issue, PR

#1545

@AppVeyorBot
Copy link

✅ Build sakura 1.0.3468 completed (commit 2962b05991 by @k-kagari)

@sonarcloud
Copy link

sonarcloud bot commented Feb 21, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@kengoide kengoide marked this pull request as ready for review February 21, 2021 14:50
berryzplus
berryzplus approved these changes Feb 21, 2021
View reviewed changes
Copy link
Contributor

@berryzplus berryzplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

問題なさそうに見えます。

@kengoide
Copy link
Member Author

ありがとうございます。マージします。

@kengoide kengoide merged commit 030b0d9 into sakura-editor:master Feb 21, 2021
@kengoide kengoide deleted the feature/cleanup-ctextmetrics branch February 21, 2021 15:59
@beru beru added the refactoring リファクタリング 【ChangeLog除外】 label Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berryzplus berryzplus berryzplus approved these changes

Assignees
No one assigned
Labels
refactoring リファクタリング 【ChangeLog除外】
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kengoide @AppVeyorBot @berryzplus @beru