Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeFactorで検出された空のif文を削除する #1446

Merged
merged 4 commits into from
Oct 28, 2020
Merged

CodeFactorで検出された空のif文を削除する #1446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d4e42d7
CodeFactorの警告対策として空のif文を除去する
berryzplus Oct 28, 2020
caa0148
CodeFactorの警告対策として無駄なif文を除去する
berryzplus Oct 28, 2020
c1704c5
CodeFactorの警告対策として空のif文を除去する
berryzplus Oct 28, 2020
dca955a
CodeFactorの警告対策として空のif文を除去する
berryzplus Oct 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions sakura_core/dlg/CDlgJump.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,9 +249,6 @@ void CDlgJump::SetData( void )
nIndex = 0;
nPLSQLBlockNum = 0;
for( i = 0; i < cFuncInfoArr.GetNum(); ++i ){
if( 31 == cFuncInfoArr.GetAt( i )->m_nInfo ||
41 == cFuncInfoArr.GetAt( i )->m_nInfo ){
}
if( 31 == cFuncInfoArr.GetAt( i )->m_nInfo ){
if( m_pShareData->m_bLineNumIsCRLF_ForJump ){ /* 行番号の表示 false=折り返し単位／true=改行単位 */
auto_sprintf( szText, LS(STR_DLGJUMP_PSLQL),
Expand Down
3 changes: 1 addition & 2 deletions sakura_core/prop/CPropComKeyword.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,8 +576,7 @@ void CPropKeyword::Clean_List_KeyWord( HWND hwndDlg, HWND hwndLIST_KEYWORD )
{
if( IDYES == ::MessageBox( hwndDlg, LS(STR_PROPCOMKEYWORD_DEL),
GSTR_APPNAME, MB_YESNO | MB_ICONQUESTION ) ){ // 2009.03.26 ryoji MB_ICONSTOP->MB_ICONQUESTION
if( m_Common.m_sSpecialKeyword.m_CKeyWordSetMgr.CleanKeyWords( m_Common.m_sSpecialKeyword.m_CKeyWordSetMgr.m_nCurrentKeyWordSetIdx ) ){
}
m_Common.m_sSpecialKeyword.m_CKeyWordSetMgr.CleanKeyWords( m_Common.m_sSpecialKeyword.m_CKeyWordSetMgr.m_nCurrentKeyWordSetIdx );
SetKeyWordSet( hwndDlg, m_Common.m_sSpecialKeyword.m_CKeyWordSetMgr.m_nCurrentKeyWordSetIdx );
}
}
Expand Down
7 changes: 5 additions & 2 deletions sakura_core/view/CEditView.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,8 +289,11 @@ BOOL CEditView::Create(
wc.hbrBackground = (HBRUSH)NULL/*(COLOR_WINDOW + 1)*/;
wc.lpszMenuName = NULL;
wc.lpszClassName = GSTR_VIEWNAME;
if( 0 == ::RegisterClass( &wc ) ){
}

// TODO: 実装を改善する余地があります。
// RegisterClassは既に登録された状態で呼ぶと失敗するため、
// 単純に成否チェックして抜けたらマズいです。
::RegisterClass( &wc );

/* エディタウィンドウの作成 */
SetHwnd(
Expand Down
2 changes: 0 additions & 2 deletions sakura_core/view/CEditView_Mouse.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,8 +422,6 @@ normal_action:;
}
}

if( 0 < nWorkRel ){
}
/* 選択領域描画 */
GetSelectionInfo().DrawSelectArea();
}
Expand Down