MinGW のコンパイルエラーを修正する #1299
Merged
MinGW のコンパイルエラーを修正する #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that GCC 10.1 reports errors inside #if 0 ... #endif. Use comments properly even inside #if.
|
✅ Build sakura 1.0.2809 completed (commit 951233cc9b by @k-takata) |
「さすがっす」といえば |
HoppingTappy
pushed a commit
to HoppingTappy/sakura
that referenced
this pull request
Jun 16, 2020
MinGW のコンパイルエラーを修正する
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR の目的
(Close #1298)
#1298 のコンパイルエラーを修正する。
カテゴリ
PR の背景
GCC 10.1 を使うとコンパイルエラーになる。
仕様・動作説明
どうやら GCC では
#ifでコンパイル対象とならない部分も、文法チェックを行うようになった模様。#if 0で無効化されている部分も、正しくコメントを使うようにする。テスト内容
CI が通ることを確認する。
PR の影響範囲
#if 0で無効化されている部分の修正のため、MinGW ビルド以外には影響なし。関連 issue, PR
#1298