Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sakura_lang_en_US.dll のバージョンにGitHash が含まれない #157

Closed
m-tmatma opened this issue Jun 22, 2018 · 3 comments
Closed

sakura_lang_en_US.dll のバージョンにGitHash が含まれない #157

m-tmatma opened this issue Jun 22, 2018 · 3 comments
Labels
🐛bug🦋 ■バグ修正(Something isn't working)
Milestone
v2.4.0

Comments

@m-tmatma
Copy link
Member

m-tmatma commented Jun 22, 2018 •
edited
Loading

sakura_lang_en_US.dll にGitHash が含まれない

sakura/sakura_lang_en_US/sakura_lang_rc.rc

Lines 5 to 11 in 53b1d94

#ifndef SAKURA_LANG_RESOURCE
#include "sakura_rc.h"
#include "Funccode_define.h"
#include "String_define.h"
#else
#include "sakura_lang.h"
#endif

sakura/sakura_core/sakura_rc.rc

Lines 5 to 12 in 53b1d94

#ifndef SAKURA_LANG_RESOURCE
#include "sakura_rc.h"
#include "Funccode_define.h"
#include "gitrev.h"
#include "String_define.h"
#else
#include "sakura_lang.h"
#endif

@m-tmatma m-tmatma changed the title sakura_lang_en_US.dll に sakura_lang_en_US.dll にGitHash が含まれない Jun 22, 2018
@m-tmatma
Copy link
Member Author

途中で登録されてしまったので、修正しました。

m-tmatma added a commit to m-tmatma/sakura that referenced this issue Jun 22, 2018
@m-tmatma
sakura-editor#157: GitHash が反映されない問題を修正
1f7a420
@m-tmatma m-tmatma mentioned this issue Jun 22, 2018
Merged
@m-tmatma m-tmatma added the 🐛bug🦋 ■バグ修正(Something isn't working) label Jun 22, 2018
@m-tmatma m-tmatma added this to the next release milestone Jun 22, 2018
@m-tmatma
Copy link
Member Author

#159 の PR 作成した。

@m-tmatma m-tmatma changed the title sakura_lang_en_US.dll にGitHash が含まれない sakura_lang_en_US.dll のバージョンにGitHash が含まれない Jun 23, 2018
@kobake
Copy link
Member

kobake commented Jun 23, 2018

ご対応ありがとうございました！

@kobake kobake closed this as completed Jun 23, 2018
berryzplus pushed a commit to berryzplus/sakura-editor that referenced this issue Jul 5, 2018
@m-tmatma @berryzplus
sakura-editor#157: GitHash が反映されない問題を修正
dcec803
@ds14050 ds14050 added the 🐛bug🦋 ■バグ修正(Something isn't working) label Sep 18, 2018
HoppingTappy pushed a commit to HoppingTappy/sakura that referenced this issue Jun 11, 2019
@m-tmatma
sakura-editor#157: GitHash が反映されない問題を修正
b0472e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛bug🦋 ■バグ修正(Something isn't working)
Projects
None yet
Milestone
v2.4.0
Development

No branches or pull requests
3 participants
@kobake @m-tmatma @ds14050