[4.0] Pluginless lazyloading for the core (joomla#30748)

* remove the plugin code * make sure there is no error message on attributs passed as string * implement width & height into the media field * add width & hight to com_media * add width & height to the file list * fix file path * add width & heigth to the media field * there is no alt text comming from com_media yet * patch JS thanks @dgrammatiko * Update installation/sql/postgresql/base.sql Co-authored-by: Quy <[email protected]> * Update installation/sql/mysql/base.sql Co-authored-by: Quy <[email protected]> * fix issues mention vy @dgrammatiko and implement width and heigth in the intro and full image layout * When we have no image nothing is going to be displayed * move json_decode & change back to the original image url * take off px for width and height * reset other changes that has been moved to joomla#30784 * also reset the image list layout * Update libraries/src/HTML/HTMLHelper.php * Add update SQL scripts 4.0.0-2020-09-27.sql (joomla#47) Co-authored-by: Quy <[email protected]> Co-authored-by: Richard Fath <[email protected]>
sakiss · Oct 16, 2020 · 605f2ef · 605f2ef
1 parent f7eca22
commit 605f2ef
Show file tree

Hide file tree

Showing 11 changed files with 4 additions and 91 deletions.
diff --git a/administrator/components/com_admin/sql/updates/mysql/4.0.0-2020-04-18.sql b/administrator/components/com_admin/sql/updates/mysql/4.0.0-2020-04-18.sql
diff --git a/administrator/components/com_admin/sql/updates/mysql/4.0.0-2020-09-27.sql b/administrator/components/com_admin/sql/updates/mysql/4.0.0-2020-09-27.sql
@@ -0,0 +1 @@
+DELETE FROM `#__extensions` WHERE `name` = 'plg_content_imagelazyload' AND `type` = 'plugin' AND `element` = 'imagelazyload' AND `folder` = 'content' AND `client_id` = 0;
diff --git a/administrator/components/com_admin/sql/updates/postgresql/4.0.0-2020-04-18.sql b/administrator/components/com_admin/sql/updates/postgresql/4.0.0-2020-04-18.sql
diff --git a/administrator/components/com_admin/sql/updates/postgresql/4.0.0-2020-09-27.sql b/administrator/components/com_admin/sql/updates/postgresql/4.0.0-2020-09-27.sql
@@ -0,0 +1 @@
+DELETE FROM "#__extensions" WHERE "name" = 'plg_content_imagelazyload' AND "type" = 'plugin' AND "element" = 'imagelazyload' AND "folder" = 'content' AND "client_id" = 0;
diff --git a/administrator/language/en-GB/plg_content_imagelazyload.sys.ini b/administrator/language/en-GB/plg_content_imagelazyload.sys.ini
diff --git a/installation/sql/mysql/base.sql b/installation/sql/mysql/base.sql
@@ -362,8 +362,7 @@ INSERT INTO `#__extensions` (`package_id`, `name`, `type`, `element`, `folder`,
 (0, 'plg_system_webauthn', 'plugin', 'webauthn', 'system', 0, 1, 1, 0, 1, '', '{}', '', 0, 0),
 (0, 'plg_workflow_publishing', 'plugin', 'publishing', 'workflow', 0, 1, 1, 0, 1, '', '{}', '', 0, 0),
 (0, 'plg_workflow_featuring', 'plugin', 'featuring', 'workflow', 0, 1, 1, 0, 1, '', '{}', '', 0, 0),
-(0, 'plg_workflow_notification', 'plugin', 'notification', 'workflow', 0, 1, 1, 0, 1, '', '{}', '', 0, 0),
-(0, 'plg_content_imagelazyload', 'plugin', 'imagelazyload', 'content', 0, 0, 1, 0, 1, '', '{}', '', 0, 0);
+(0, 'plg_workflow_notification', 'plugin', 'notification', 'workflow', 0, 1, 1, 0, 1, '', '{}', '', 0, 0);
 
 -- Templates
 INSERT INTO `#__extensions` (`package_id`, `name`, `type`, `element`, `folder`, `client_id`, `enabled`, `access`, `protected`, `locked`, `manifest_cache`, `params`, `custom_data`, `ordering`, `state`) VALUES

diff --git a/installation/sql/postgresql/base.sql b/installation/sql/postgresql/base.sql
@@ -368,8 +368,7 @@ INSERT INTO "#__extensions" ("package_id", "name", "type", "element", "folder",
 (0, 'plg_system_webauthn', 'plugin', 'webauthn', 'system', 0, 1, 1, 0, 1, '', '{}', '', 0, 0),
 (0, 'plg_workflow_publishing', 'plugin', 'publishing', 'workflow', 0, 1, 1, 0, 1, '', '{}', '', 0, 0),
 (0, 'plg_workflow_featuring', 'plugin', 'featuring', 'workflow', 0, 1, 1, 0, 1, '', '{}', '', 0, 0),
-(0, 'plg_workflow_notification', 'plugin', 'notification', 'workflow', 0, 1, 1, 0, 1, '', '{}', '', 0, 0),
-(0, 'plg_content_imagelazyload', 'plugin', 'imagelazyload', 'content', 0, 0, 1, 0, 1, '', '{}', '', 0, 0);
+(0, 'plg_workflow_notification', 'plugin', 'notification', 'workflow', 0, 1, 1, 0, 1, '', '{}', '', 0, 0);
 
 -- Templates
 INSERT INTO "#__extensions" ("package_id", "name", "type", "element", "folder", "client_id", "enabled", "access", "protected", "locked", "manifest_cache", "params", "custom_data", "ordering", "state") VALUES

diff --git a/libraries/src/Extension/ExtensionHelper.php b/libraries/src/Extension/ExtensionHelper.php
@@ -182,7 +182,6 @@ class ExtensionHelper
 		array('plugin', 'emailcloak', 'content', 0),
 		array('plugin', 'fields', 'content', 0),
 		array('plugin', 'finder', 'content', 0),
-		array('plugin', 'imagelazyload', 'content', 0),
 		array('plugin', 'joomla', 'content', 0),
 		array('plugin', 'loadmodule', 'content', 0),
 		array('plugin', 'pagebreak', 'content', 0),

diff --git a/libraries/src/HTML/HTMLHelper.php b/libraries/src/HTML/HTMLHelper.php
@@ -1273,4 +1273,3 @@ private static function checkFileOrder($first, $second)
 		return '';
 	}
 }
-
diff --git a/plugins/content/imagelazyload/imagelazyload.php b/plugins/content/imagelazyload/imagelazyload.php
diff --git a/plugins/content/imagelazyload/imagelazyload.xml b/plugins/content/imagelazyload/imagelazyload.xml
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		DELETE FROM `#__extensions` WHERE `name` = 'plg_content_imagelazyload' AND `type` = 'plugin' AND `element` = 'imagelazyload' AND `folder` = 'content' AND `client_id` = 0;
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		DELETE FROM "#__extensions" WHERE "name" = 'plg_content_imagelazyload' AND "type" = 'plugin' AND "element" = 'imagelazyload' AND "folder" = 'content' AND "client_id" = 0;
Original file line number	Diff line number	Diff line change
Expand Up		@@ -1273,4 +1273,3 @@ private static function checkFileOrder($first, $second)
		return '';
		}
		}