Fixing system tests and codestyle (joomla#80)

* Fixing system tests and codestyle * Fixing Postgres
sakiss · Oct 16, 2020 · 005df37 · 005df37
1 parent a96f47a
commit 005df37
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 15 deletions.
diff --git a/administrator/components/com_content/src/Model/ArticlesModel.php b/administrator/components/com_content/src/Model/ArticlesModel.php
@@ -610,16 +610,17 @@ public function getTransitions()
 					]
 				)
 					->from($db->quoteName('#__workflow_transitions', 't'))
-					->innerJoin($db->quoteName('#__workflow_stages', 's'))
+					->innerJoin(
+						$db->quoteName('#__workflow_stages', 's'),
+						$db->quoteName('t.to_stage_id') . ' = ' . $db->quoteName('s.id')
+					)
 					->where(
 						[
-							$db->quoteName('t.to_stage_id') . ' = ' . $db->quoteName('s.id'),
 							$db->quoteName('t.published') . ' = 1',
 							$db->quoteName('s.published') . ' = 1',
 						]
 					)
-					->order($db->quoteName('t.ordering'))
-					->group($db->quoteName('t.id'));
+					->order($db->quoteName('t.ordering'));
 
 				$where = [];
 

diff --git a/composer.lock b/composer.lock
diff --git a/libraries/src/Workflow/Workflow.php b/libraries/src/Workflow/Workflow.php
@@ -371,10 +371,12 @@ public function getAssociation(int $item_id): ?\stdClass
 			]
 		)
 			->from($db->quoteName('#__workflow_associations', 'a'))
-			->innerJoin($db->quoteName('#__workflow_stages', 's'))
+			->innerJoin(
+				$db->quoteName('#__workflow_stages', 's'),
+				$db->quoteName('a.stage_id') . ' = ' . $db->quoteName('s.id')
+			)
 			->where(
 				[
-					$db->quoteName('a.stage_id') . ' = ' . $db->quoteName('s.id'),
 					$db->quoteName('item_id') . ' = :id',
 					$db->quoteName('extension') . ' = :extension',
 				]

diff --git a/plugins/workflow/publishing/publishing.php b/plugins/workflow/publishing/publishing.php
@@ -184,7 +184,8 @@ protected function enhanceItemForm(Form $form, $data)
 
 		$form->setFieldAttribute($fieldname, 'type', 'spacer');
 
-		$form->setFieldAttribute($fieldname, 'label', Text::sprintf('PLG_WORKFLOW_PUBLISHING_PUBLISHED', '<span class="text-' . $textclass . '">' . htmlentities($text, ENT_COMPAT, 'UTF-8') . '</span>'));
+		$label = '<span class="text-' . $textclass . '">' . htmlentities($text, ENT_COMPAT, 'UTF-8') . '</span>';
+		$form->setFieldAttribute($fieldname, 'label', Text::sprintf('PLG_WORKFLOW_PUBLISHING_PUBLISHED', $label));
 
 		return true;
 	}

diff --git a/tests/Codeception/_support/Step/Acceptance/Administrator/Content.php b/tests/Codeception/_support/Step/Acceptance/Administrator/Content.php
@@ -121,7 +121,7 @@ public function unPublishArticle($title)
 		$I->checkAllResults();
 		$I->clickToolbarButton('Action');
 		$I->wait(2);
-		$I->clickToolbarButton('unpublish');
+		$I->clickToolbarButton('transition', '1');
 		$I->filterByCondition($title, "Unpublished");
 	}
 
@@ -144,7 +144,7 @@ public function publishArticle($title)
 		$I->checkAllResults();
 		$I->clickToolbarButton('Action');
 		$I->wait(2);
-		$I->clickToolbarButton('publish');
+		$I->clickToolbarButton('transition', '2');
 		$I->filterByCondition($title, "Published");
 	}
 
@@ -168,7 +168,7 @@ public function trashArticle($title)
 		$I->checkAllResults();
 		$I->clickToolbarButton('Action');
 		$I->wait(2);
-		$I->clickToolbarButton('trash');
+		$I->clickToolbarButton('transition', '3');
 		$I->filterByCondition($title, "Trashed");
 	}
 
@@ -210,7 +210,7 @@ public function filterByCondition($title, $condition)
 		$I = $this;
 		$I->click("//div[@class='js-stools-container-bar']//button[contains(text(), 'Filter')]");
 		$I->wait(2);
-		$I->selectOptionInChosenByIdUsingJs('filter_condition', $condition);
+		$I->selectOptionInChosenByIdUsingJs('filter_published', $condition);
 		$I->see($title);
 	}
 }