Skip to content

Commit

Permalink
remove duplicate dyf file warning from preview generation process (Dy…
Browse files Browse the repository at this point in the history
…namoDS#14711)

- dynamo would issue a warning and fail to publish a package if an 'unqualified' file is being used, such as a dyf file already under package control
- this check is done when publishing package locally, but I have incorrectly added it to the process of creating a build preview, which stops the process for both local and online submit workflow

(cherry picked from commit 3ea1c5c)
  • Loading branch information
dnenov authored and saintentropy committed Dec 9, 2023
1 parent 4da00ab commit 023da4a
Showing 1 changed file with 0 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2411,22 +2411,6 @@ private void PreviewPackageBuild()
.ToList();
try
{
var unqualifiedFiles = GetAllUnqualifiedFiles();

if (files == null || files.Count() < 1 || unqualifiedFiles.Count() > 0)
{
string filesCannotBePublished = null;
foreach (var file in unqualifiedFiles)
{
filesCannotBePublished = filesCannotBePublished + file + "\n";
}
string FileNotPublishMessage = string.Format(Resources.FileNotPublishMessage, filesCannotBePublished);
UploadState = PackageUploadHandle.State.Error;
MessageBoxResult response = DynamoModel.IsTestMode ? MessageBoxResult.OK : MessageBoxService.Show(Owner, FileNotPublishMessage, Resources.FileNotPublishCaption, MessageBoxButton.OK, MessageBoxImage.Error);

return;
}

// Generate the Package Name, either based on the user 'Description', or the root path name, if no 'Description' yet
var packageName = !string.IsNullOrEmpty(Name) ? Name : Path.GetFileName(publishPath);
var rootItemPreview = RetainFolderStructureOverride ?
Expand Down

0 comments on commit 023da4a

Please sign in to comment.