Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when the
usernameCaseInsensitive
option is enabled then username is queried using regex constructed from unescaped username value.This is a bit problematic because username can often contain special characters - e.g. it can be
[email protected]
email address.When we construct regex from that value then it will treat plus sign as a regex quantifier rather than character match. Here's how it fails:
And this leads to inability to authenticate using that email address after it was used for registration. It can also potentially lead to some security/stability vulnerabilities, like e.g. ReDoS.
My solution here is to escape regex token characters in username before that value gets put into RegExp constructor.