Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

g:fzf_colors on light background makes the text invisible in fzf window #5

Closed
janlazo opened this issue Dec 14, 2019 · 4 comments
Closed

Comments

@janlazo
Copy link

janlazo commented Dec 14, 2019

g:fzf_colors is okay in dark background.

Tested with fzf.vim, GFiles command, termguicolors on, light background.

Workaround is to use an autocmd to unlet g:fzf_colors after setting the colorscheme.

@sainnhe
Copy link
Owner

sainnhe commented Dec 14, 2019

I'm unable to reproduce this.

Minimal configuration:

if has('nvim')
    set runtimepath^=~/.vim runtimepath+=~/.vim/after
    let &packpath = &runtimepath
endif
call plug#begin('~/.cache/vim/plugins')
Plug 'junegunn/fzf'
Plug 'junegunn/fzf.vim'
Plug 'sainnhe/edge', { 'as': 'vim-color-edge' }
call plug#end()

set termguicolors
set background=light

augroup testFzf
    autocmd!
    autocmd ColorScheme * unlet g:fzf_colors
augroup END

colorscheme edge

Demo:

demo

I think this is visible enough, please provide steps to reproduce it.

In addition, why do you want to unlet g:fzf_colors? This color scheme is optimized specifically for fzf.

@janlazo
Copy link
Author

janlazo commented Dec 14, 2019

nvim-qt_nvim-0 5 0_ubuntu

neovim-qt, nvim 0.5.0, Ubuntu 16.04

gvim_vim-8 1 2380_win10

GVim, Vim 8.2 Windows 10 (Edge VM).
I can't replicate the invisible text on the VM. I saw it on my Windows work machine only so I'll add the screenshot if needed next week.

I don't want to unlet g:fzf_colors but I don't know how else to avoid it. Perhaps set g:fzf_colors only if not running on Windows.

@janlazo
Copy link
Author

janlazo commented Dec 14, 2019

nvim-qt_nvim-0 5 0_win10

nvim-qt, nvim 0.5.0, Windows 10 (Edge VM).
I reproduced here.

janlazo added a commit to janlazo/fzf that referenced this issue Dec 15, 2019
Truecolor does not work on default Windows terminal.
It is a problem in neovim GUIs.

sainnhe/edge#5 (comment)
@janlazo
Copy link
Author

janlazo commented Dec 15, 2019

I'll mitigate the text,background color issue in upstream instead.

@janlazo janlazo closed this as completed Dec 15, 2019
junegunn pushed a commit to junegunn/fzf that referenced this issue Dec 15, 2019
Truecolor does not work on default Windows terminal.
It is a problem in neovim GUIs.

sainnhe/edge#5 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants