Implement as.tbl_json.data.frame for #27 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assert_that(json.column %in% names(x)) | ||
|
|
||
| # Parse the json | ||
| json <- lapply(x[[json.column]], fromJSON, simplifyVector = FALSE) |
There was a problem hiding this comment.
is it clear which fromJSON will get applied? If the user uses both jsonlite and rjson, does it matter which one gets used? rjson::fromJSON might be a good replacement
There was a problem hiding this comment.
And to that end, we should make all of tidyJSON's 3rd party library calls explicit, via: library::method
There was a problem hiding this comment.
It's actually jsonlite::fromJSON that is used. jsonlite is imported in R/tidyjson-package.r, and R package namespaces will guarantee tidyjson will always use the jsonlite version of fromJSON.
|
after you address my comment, +1 |
jeremystan
pushed a commit
that referenced
this pull request
Apr 3, 2015
Implement as.tbl_json.data.frame, closes #27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27