Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for logging interfering with multipart uploads #50

Merged
merged 1 commit into from
May 16, 2024

Conversation

marcelhamel
Copy link
Contributor

A proposed solution for Issue #49, where an effort to log a multipart payload by creating a duplicate object inadvertently modifies the request payload itself. The result was that multipart requests to the Job API were sending a string meant for logging rather than a file, and this was somehow triggering the signature hash error message.

This is a one-line fix which should preserve the integrity of the request payload.

@expe
Copy link
Contributor

expe commented May 16, 2024

Thanks @marcelhamel for the PR, just checked that this does fix the multipart uploads.

@expe expe merged commit f320361 into sailthru:master May 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants