Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the translation file got into the correct place #69

Closed
wants to merge 1 commit into from
Closed

Conversation

ruditimmermans
Copy link
Contributor

Fix the translation file got into the correct place, also update the version into the specs and filecase.qml, i have compile this with the sdk and translations would be there...

…version into the specs and filecase.qml, i have compile this with the sdk and translations would be there...
@Olf0 Olf0 changed the base branch from master to devel February 21, 2024 23:10
@Olf0 Olf0 changed the base branch from devel to master February 21, 2024 23:12
@Olf0 Olf0 marked this pull request as draft February 24, 2024 04:18
@Olf0
Copy link
Collaborator

Olf0 commented Feb 24, 2024

@ruditimmermans, thank you for your contribution. Two comments on why I changed this PR to draft status:

  • Please link PR to the corresponding issue report by mentioning it. It took a while until I found that this PR addresses issue [Bug] TS files are not translated to QM files when building on OBS #68.
  • The default branch is devel (also called "tip", i.e. the current development code), hence you need to apply your changes atop the current state of devel and direct your PRs to devel. I tried to rectify this by changing the base branch to devel, but this does not work, because you applied your changes atop the current state of the master branch (if I would stubbornly merge this, it would create a circular commit chain, which git does not handle well at all).
  • I am not sure that the changes are required in filecase.pro:
    i18n_files.files = translations
    i18n_files.path = /usr/share/$$TARGET
    
    INSTALLS += i18n_files
    
    I will try to check, but AFAICS this change you suggested changes just set the default values explicitly.

Olf0 added a commit that referenced this pull request Feb 24, 2024
… by cherry-picking and extending PR #69.
@Olf0
Copy link
Collaborator

Olf0 commented Feb 24, 2024

After some testing I am sure that this is nonsense (as suspected above), because the error message has always been (but nobody looked at it):
[ 228s] lupdate: could not exec '/usr/lib/qt5/bin/lupdate': No such file or directory
[ 228s] lrelease: could not exec '/usr/lib/qt5/bin/lrelease': No such file or directory

@Olf0 Olf0 closed this Feb 24, 2024
Olf0 added a commit that referenced this pull request Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants