-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for valid uses of @ts-expect-error
#652
Comments
🎉 This issue has been resolved in version 1.0.7 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version 1.0.7 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version 1.1.60 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version 2.1.7 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version 1.0.36 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version 1.8.10 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version 2.4.2 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version 2.3.2 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Realistically, we'll run into the "type instantiation..." errors, no matter what we do. String parsing in typescript is somewhat of an absurd premise, and breaks in it are somewhat inevitable, especially with massive GROQ queries.
I believe we should have two sections:
specific-issues.test.ts
file and make a PR, gives the best starting point. Thetypes
andgroq
packages are usually where these should go.@ts-expect-error
and manual typing to patch a solution in.This isn't an ideal world, where they'll likely have a
@ts-expect-error
in their codebase for quite a long time. But some migrations are massive (@judofyr knows) and, realistically, these issues are relatively common and need an "out". Otherwise, users will just bail altogether. Especially since this is an open source library that I spend my spare time on, meaning some of these issues might linger.The text was updated successfully, but these errors were encountered: