Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle singular and plural forms for word, minute and post counts #161

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Marcos03BR
Copy link
Contributor

Updated the word and minute count display in both PostCard.astro and [...slug].astro to correctly handle singular forms when the count is 1. This ensures proper grammar by dynamically selecting the appropriate form based on the count value.

…rd.astro and [...slug].astro

Updated the word and minute count display in both PostCard.astro and [...slug].astro to correctly handle singular forms when the count is 1. This ensures proper grammar by dynamically selecting the appropriate form based on the count value.
Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuwari-yags ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 10:05pm

Add conditional logic to display 'postCount' for single post and 'postsCount' for multiple posts in the group list.
@Marcos03BR Marcos03BR changed the title Handle singular and plural forms for word and minute counts in PostCard.astro and [...slug].astro Handle singular and plural forms for word, minute and post counts in PostCard.astro and [...slug].astro Aug 28, 2024
@Marcos03BR Marcos03BR changed the title Handle singular and plural forms for word, minute and post counts in PostCard.astro and [...slug].astro Handle singular and plural forms for word, minute and post counts Aug 28, 2024
@@ -68,18 +68,22 @@ function formatTag(tag: string[]) {
<div class="card-base px-8 py-6">
{
groups.map(group => (
<div>
<div key={group.year}>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explain the purpose of adding this attribute?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my first project using Astro, so I’m still learning. In React, it’s considered a good practice to use key when generating lists with map to optimize rendering and avoid potential issues, as it helps uniquely identify each element. Since Astro has some similarities, I thought applying it here might be beneficial, although I’m not sure if it’s strictly necessary. If you feel it doesn’t add value in this case, feel free to remove it, as it works the same without it.

Copy link
Owner

@saicaca saicaca Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is unnecessary in Astro since there is no dynamic element updating. If you have time, could you help me remove these attributes? I'm worried that I might forget why they are here in the future.🥲

Added link to the Spanish readme
aria-label={post.data.title}
class="group btn-plain block h-10 w-full rounded-lg hover:text-[initial]"
<a
key={post.slug}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well

@Marcos03BR
Copy link
Contributor Author

Done! Sorry for taking so long

README.md Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay. Could you please revert this deletion? Since it causes a conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants