-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alt mains tidy up #483
Alt mains tidy up #483
Conversation
I have a feeling |
You're probably right. I de-inlines the two procedures that called
It's probably a bit of a stretch to classify Thoughts? |
@SeeSpotRun They are likely I/O bound in the sense that the function call overhead is negligible compared to the cost of calling For single line wrapper functions, I think it's good practice to make them inline or macros regardless of what they do. |
I was unsure of the reason for the recommendation "We should not use functions that are I/O bound as inline functions" and feared that they might make things worse. On reading further it seems the reason is that they don't give much speed improvement, rather than that they make things worse.
Ok, will revert those. |
Addresses #458
Alternate mains
--hash
,--is-reflink
and--dedupe
all have stand-alone option parsing. The--[hash|is-reflink|dedupe]
must be first arg.Alternate main
--gui
--shredder
does no option parsing but instead passes all args to the python script.Note:
rmlint --equal
still uses main option parsing but that is probable appropriate.