[Makefile] Support reproducible builds #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Embedding build times is generally poor form as it introduces undeterministic builds. To ensure the binaries are reproducible, we should be looking for `SOURCE_DATE_EPOCH` in the build environment as specified by the reproducible builds project. https://reproducible-builds.org/docs/source-date-epoch/
|
Hey @Foxboron! Thanks a lot, this is great. TBH I care little about the build time, because the commit hash provides authoritative information. (Probably a build number would be better, because that could identify actual builds in the build system) But with this addition I think we can leave it there. Thanks again! |
|
Yes, we completely agree. I however felt that supporting |
|
I opened an issue so that I don't forget about it. But eventually I will probably just remove it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embedding build times is generally poor form as it introduces
undeterministic builds. To ensure the binaries are reproducible, we
should be looking for
SOURCE_DATE_EPOCHin the build environment asspecified by the reproducible builds project.
https://reproducible-builds.org/docs/source-date-epoch/