Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static: reinstate fixed navbar via flex #4026

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Conversation

haraldschilly
Copy link
Contributor

@haraldschilly haraldschilly commented Aug 21, 2019

Description

Testing Steps

I tested this in chrome and FF

Relevant Issues

Checklist:

  • No debugging console.log messages.
  • All new code is actually used.
  • Non-obvious code has some sort of comments.

Front end:

  • Restart at least one project and check its ~/.smc/local_hub/local_hub.log
  • Completely restart Webpack with ./w in /src
  • Completely restart the hub by killing and restarting ./start_hub.py in /src/dev/project
  • Screenshots if relevant.

@haraldschilly haraldschilly force-pushed the fix-static-header branch 2 times, most recently from 472a97a to 69cc75f Compare August 21, 2019 13:56
@williamstein
Copy link
Contributor

What did you change? It's a LOT of work to tell from this patch, because you moved all the relevant code to another file, then changed it there...

@williamstein
Copy link
Contributor

Well, I don't understand this, but it seems harmless, and worse case I can revert.

@williamstein williamstein merged commit 74ffab1 into master Aug 21, 2019
@haraldschilly
Copy link
Contributor Author

yes, I also cleaned this up a bit, makes it hard to follow. The key idea is to split the top part in two divs and then

body
  display: flex
  flex-direction: column
  height: 100vh
  overflow: hidden

div#content
  flex: 1 1 auto
  overflow: auto

nav#nav-main
  flex: 0 0 auto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants